Make Repo Public + Library on NPM

- sealer & voting-authority backend -> need bignumber.js as dev dependency due to web3js bug: web3/web3.js#3386
- remove all .npmrc files (no longer needed, @meck93/evote-crypto is a public npm package)
- remove github.json and reading github config from most build scripts since it's no longer needed

Author: meck93

.npmrc

@@ -26,22 +26,18 @@ sudo apt-get install jq
 sudo dnf install jq
 ```
 
-### Crypto Private Github Package
+### Github Packages & Github Config JSON (Important!)
 
-Since the crypto library (evote-crypto) is a private npm package, you need to be logged in to the Github package registry in order to be able to download the package.
-`npm login --registry=https://npm.pkg.github.com`
+The pre-built docker images are hosted on Gitub Packages. Accessing the images is currently only possible when logged in to: `docker.pkg.github.com`.
+You will need a Github personal access token with `repo, package:read` permission. Unlock this in your Github account.
 
-You will need a Github personal access token with `package:read, package:write` permission. Unlock this in your Github account.
-
-#### Github Config JSON
-
-Create a JSON file in the top-level folder (`/github.json`) which has the following structure, if it does not exist yet. Insert your credentials and personal information in there.
+Create a JSON file in the top-level folder (`/github.json`) which has the following structure, if it does not exist yet.
+Insert your credentials and personal information in there.
 
 ```json
 {
   "github": {
     "user": "",
-    "email": "",
     "token": ""
   }
 }

README.md

@@ -12,6 +12,7 @@ GITHUB_TOKEN=$(cat $githubConfig | jq .github.token | tr -d \")
 GITHUB_USER=$(cat $githubConfig | jq .github.user | tr -d \")
 
 # login into docker package registry
+# -> this is required even if the images are public (Github Packages Limitation)
 docker login docker.pkg.github.com --username $GITHUB_USER --password $GITHUB_TOKEN
 
 # create docker network

contracts/.npmrc

@@ -8,12 +8,12 @@ echo '##############################################'
 echo
 
 if [[ $1 == '--build' ]]; then
-    
+
     echo '> building docker containers'
     shouldBuild=1
 else
     echo '> using existing containers...'
-    echo '> if you wish to build the docker containers, run:' 
+    echo '> if you wish to build the docker containers, run:'
     echo '> ./docker-up.sh --build'
 fi
 
@@ -37,7 +37,7 @@ echo
 echo '> starting Blockchain Explorer Dashboard'
 ./ethstats/docker-start.sh $shouldBuild
 
-echo 
+echo
 echo '-------------------------------------------------'
 echo '> Running Docker Containers'
 echo '-------------------------------------------------'

contracts/package-lock.json

@@ -1,9 +1,5 @@
 FROM node:12-alpine as builder
 
-# variables used to perform npm-cli-login
-ARG GITHUB_TOKEN
-ARG GITHUB_USER
-ARG GITHUB_EMAIL
 ARG SB_PORT
 ARG SB_IP
 ARG SF_PORT
@@ -36,13 +32,8 @@ WORKDIR /usr/src
 # install build dependencies
 RUN apk add --no-cache bash python make g++ gcc openssh-client git
 
-# copy the backend folder
+# copy the backend folder and install the backend
 COPY ./backend ./backend
-
-# install npm cli login to retrieve private package from github
-RUN npm install -g npm-cli-login
-RUN NPM_USER=${GITHUB_USER} NPM_PASS=${GITHUB_TOKEN} NPM_EMAIL=${GITHUB_EMAIL} NPM_REGISTRY=https://npm.pkg.github.com npm-cli-login
-
 RUN cd ./backend && npm i
 
 # copy the frontend folder and install the frontend

docker-prebuilt-up.sh

@@ -1,29 +1,17 @@
 FROM node:12-alpine as builder
 
-# variables used to perform npm-cli-login
-ARG GITHUB_TOKEN
-ARG GITHUB_USER
-ARG GITHUB_EMAIL
-
 # Create app directory
 WORKDIR /usr/src/backend
 
 # install build dependencies
 RUN apk add --no-cache bash python make g++ gcc openssh-client git
 
-# copy package json
+# copy package json, .npmrc and install dependencies
 COPY package*.json ./
 COPY .npmrc ./
-
-# install npm cli login to retrieve private package from github
-RUN npm install -g npm-cli-login
-RUN NPM_USER=${GITHUB_USER} NPM_PASS=${GITHUB_TOKEN} NPM_EMAIL=${GITHUB_EMAIL} NPM_REGISTRY=https://npm.pkg.github.com npm-cli-login
-
 RUN npm install
-# If you are building your code for production
-# RUN npm ci --only=production
 
-FROM node:12-alpine 
+FROM node:12-alpine
 
 # Create app directory
 WORKDIR /usr/src/backend

docker-up.sh

@@ -26,13 +26,6 @@ echo "The mode is: $mode"
 # - the config file with all IPs and ports
 ###########################################
 globalConfig=$parentParentDir/system.json
-githubConfig=$parentParentDir/github.json
-
-# check if the github config json exists -> if not we stop the process
-if [ ! -f "$githubConfig" ]; then
-    echo "$githubConfig doesn't exist! Please create it!"
-    exit
-fi
 
 ###########################################
 # Set Sealer Number
@@ -48,15 +41,15 @@ cp $parentParentDir/poa-blockchain/keys/sealer$sealerNr.pwd $dir/wallet/sealer.p
 ###########################################
 # ENV variables
 ###########################################
-# - Voting Authority Backend PORT (the port stays the same, in dev and prod mode) 
+# - Voting Authority Backend PORT (the port stays the same, in dev and prod mode)
 VOTING_AUTH_BACKEND_PORT=$(cat $globalConfig | jq .services.voting_authority_backend.port)
 # - Voting Authority Backend IP (either 172.1.1.XXX or localhost)
 VOTING_AUTH_BACKEND_IP=$(cat $globalConfig | jq .services.voting_authority_backend.ip.$mode | tr -d \")
 # - Sealer Backend Port (the port stays the same, in dev and prod mode)
 SEALER_BACKEND_PORT=$(cat $globalConfig | jq .services.sealer_backend_$sealerNr.port)
 # - Sealer Backend IP (either 172.1.1.XXX or localhost)
 SEALER_BACKEND_IP=$(cat $globalConfig | jq .services.sealer_backend_$sealerNr.ip.$mode | tr -d \")
-# - Sealer Frontend Port (the port stays the same, in dev and prod mode) 
+# - Sealer Frontend Port (the port stays the same, in dev and prod mode)
 SEALER_FRONTEND_PORT=$(cat $globalConfig | jq .services.sealer_frontend_$sealerNr.port)
 # - Sealer Frontend IP (either 172.1.1.XXX or localhost)
 SEALER_FRONTEND_IP=$(cat $globalConfig | jq .services.sealer_frontend_$sealerNr.ip.$mode | tr -d \")
@@ -66,10 +59,6 @@ PARITY_NODE_PORT=$(cat $globalConfig | jq .services.sealer_parity_1.port)
 PARITY_NODE_IP=$(cat $globalConfig | jq .services.sealer_parity_1.ip.$mode | tr -d \")
 # - Specify NODE_ENV
 NODE_ENV=$mode
-# - Specify the Github credentials
-GITHUB_TOKEN=$(cat $githubConfig | jq .github.token | tr -d \")
-GITHUB_EMAIL=$(cat $githubConfig | jq .github.email | tr -d \")
-GITHUB_USER=$(cat $githubConfig | jq .github.user | tr -d \")
 
 ###########################################
 # write ENV variables into .env
@@ -83,9 +72,6 @@ echo SEALER_FRONTEND_IP=${SEALER_FRONTEND_IP} >> $dir/.env
 echo PARITY_NODE_PORT=${PARITY_NODE_PORT} >> $dir/.env
 echo PARITY_NODE_IP=${PARITY_NODE_IP} >> $dir/.env
 echo NODE_ENV=${NODE_ENV} >> $dir/.env
-echo GITHUB_TOKEN=$GITHUB_TOKEN >> $dir/.env
-echo GITHUB_USER=$GITHUB_USER >> $dir/.env
-echo GITHUB_EMAIL=$GITHUB_EMAIL >> $dir/.env
 
 ###########################################
 # installing packages