Skip to content

Commit 049359c

Browse files
committed
fixed name of model from UNKNOWN_BASE_TYPE to right one in api: operationId + OneOf Fix OpenAPITools#5381 parcelableModel is not required
1 parent 6a8769e commit 049359c

File tree

4 files changed

+6
-9
lines changed

4 files changed

+6
-9
lines changed

modules/openapi-generator/src/main/java/org/openapitools/codegen/DefaultCodegen.java

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -5425,6 +5425,9 @@ public CodegenParameter fromRequestBody(RequestBody body, Set<String> imports, S
54255425
LOGGER.warn("codegenModel is null. Default to UNKNOWN_BASE_TYPE");
54265426
codegenModelName = "UNKNOWN_BASE_TYPE";
54275427
codegenModelDescription = "UNKNOWN_DESCRIPTION";
5428+
if (useOneOfInterfaces && templateDir.equals("JavaSpring")){
5429+
codegenModelName = codegenProperty.getComplexType()+"OneOf";
5430+
}
54285431
}
54295432

54305433
if (StringUtils.isEmpty(bodyParameterName)) {
@@ -5439,7 +5442,7 @@ public CodegenParameter fromRequestBody(RequestBody body, Set<String> imports, S
54395442
codegenParameter.description = codegenModelDescription;
54405443
imports.add(codegenParameter.baseType);
54415444

5442-
if (codegenProperty.complexType != null) {
5445+
if (codegenProperty.complexType != null && (useOneOfInterfaces && !templateDir.equals("JavaSpring"))) {
54435446
imports.add(codegenProperty.complexType);
54445447
}
54455448
}

modules/openapi-generator/src/main/java/org/openapitools/codegen/languages/SpringCodegen.java

Lines changed: 0 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -21,10 +21,6 @@
2121
import io.swagger.v3.oas.models.OpenAPI;
2222
import io.swagger.v3.oas.models.Operation;
2323
import io.swagger.v3.oas.models.PathItem;
24-
import io.swagger.v3.oas.models.media.ComposedSchema;
25-
import io.swagger.v3.oas.models.media.Schema;
26-
import io.swagger.v3.oas.models.parameters.RequestBody;
27-
import org.apache.commons.lang3.StringUtils;
2824
import org.apache.commons.lang3.tuple.Pair;
2925
import org.openapitools.codegen.*;
3026
import org.openapitools.codegen.languages.features.BeanValidationFeatures;
@@ -33,8 +29,6 @@
3329
import org.openapitools.codegen.meta.features.*;
3430
import org.openapitools.codegen.templating.mustache.SplitStringLambda;
3531
import org.openapitools.codegen.templating.mustache.TrimWhitespaceLambda;
36-
import org.openapitools.codegen.utils.ModelUtils;
37-
import org.openapitools.codegen.utils.OneOfImplementorAdditionalData;
3832
import org.openapitools.codegen.utils.URLPathUtils;
3933
import org.slf4j.Logger;
4034
import org.slf4j.LoggerFactory;

modules/openapi-generator/src/main/resources/JavaSpring/model.mustache

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -35,7 +35,7 @@ import org.springframework.hateoas.RepresentationModel;
3535
{{>enumOuterClass}}
3636
{{/isEnum}}
3737
{{^isEnum}}
38-
{{#vendorExtensions.x-is-one-of-interface}}{{>oneof_interface}}{{/vendorExtensions.x-is-one-of-interface}}{{^vendorExtensions.x-is-one-of-interface}}{{>pojo}}{{/vendorExtensions.x-is-one-of-interface}}
38+
{{#vendorExtensions.x-is-one-of-interface}}{{>oneof_interface}}{{/vendorExtensions.x-is-one-of-interface}}{{^vendorExtensions.x-is-one-of-interface}}{{>pojo}}{{/vendorExtensions.x-is-one-of-interface}}
3939
{{/isEnum}}
4040
{{/model}}
4141
{{/models}}

modules/openapi-generator/src/main/resources/JavaSpring/oneof_interface.mustache

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3,4 +3,4 @@ public interface {{classname}} {{#vendorExtensions.x-implements}}{{#-first}}exte
33
{{#discriminator}}
44
public {{propertyType}} {{propertyGetter}}();
55
{{/discriminator}}
6-
}
6+
}

0 commit comments

Comments
 (0)