Skip to content

Commit 8f0b477

Browse files
committed
chore: update types
1 parent 07b18f3 commit 8f0b477

File tree

2 files changed

+14
-11
lines changed

2 files changed

+14
-11
lines changed

scripts/release/process-release.ts

Lines changed: 11 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -18,6 +18,7 @@ import {
1818
gitCommit,
1919
} from '../common';
2020
import { getLanguageFolder } from '../config';
21+
import type { Language } from '../types';
2122

2223
import {
2324
RELEASED_TAG,
@@ -36,15 +37,17 @@ import type {
3637

3738
dotenv.config({ path: ROOT_ENV_PATH });
3839

39-
const BEFORE_CLIENT_GENERATION: {
40-
[lang: string]: BeforeClientGenerationCommand;
41-
} = {
40+
const BEFORE_CLIENT_GENERATION: Partial<{
41+
[lang in Language]: BeforeClientGenerationCommand;
42+
}> = {
4243
javascript: async ({ releaseType, dir }) => {
4344
await run(`yarn release:bump ${releaseType}`, { cwd: dir });
4445
},
4546
};
4647

47-
const BEFORE_CLIENT_COMMIT: { [lang: string]: BeforeClientCommitCommand } = {
48+
const BEFORE_CLIENT_COMMIT: Partial<{
49+
[lang in Language]: BeforeClientCommitCommand;
50+
}> = {
4851
javascript: async ({ dir }) => {
4952
await run(`yarn`, { cwd: dir }); // generate `yarn.lock` file
5053
await run(`git add yarn.lock`, { cwd: dir });
@@ -131,7 +134,7 @@ async function updateChangelog({
131134
current,
132135
next,
133136
}: {
134-
lang: string;
137+
lang: Language;
135138
issueBody: string;
136139
current: string;
137140
next: string;
@@ -178,10 +181,10 @@ async function processRelease(): Promise<void> {
178181

179182
await updateOpenApiTools(versionsToRelease);
180183

181-
const langsToRelease = Object.keys(versionsToRelease);
184+
const langsToRelease = Object.keys(versionsToRelease) as Language[];
182185

183186
for (const lang of langsToRelease) {
184-
const { current, releaseType } = versionsToRelease[lang];
187+
const { current, releaseType } = versionsToRelease[lang]!;
185188
/*
186189
About bumping versions of JS clients:
187190
@@ -227,7 +230,7 @@ async function processRelease(): Promise<void> {
227230
await configureGitHubAuthor(tempGitDir);
228231
await run(`git add .`, { cwd: tempGitDir });
229232

230-
const { current, releaseType } = versionsToRelease[lang];
233+
const { current, releaseType } = versionsToRelease[lang]!;
231234
const next = semver.inc(current, releaseType);
232235

233236
await BEFORE_CLIENT_COMMIT[lang]?.({

scripts/release/types.ts

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -30,12 +30,12 @@ export type Commit =
3030
| { error: 'missing-language-scope' }
3131
| { error: 'unknown-language-scope' };
3232

33-
export type VersionsToRelease = {
34-
[lang: string]: {
33+
export type VersionsToRelease = Partial<{
34+
[lang in Language]: {
3535
current: string;
3636
releaseType: ReleaseType;
3737
};
38-
};
38+
}>;
3939

4040
export type BeforeClientGenerationCommand = (params: {
4141
releaseType: ReleaseType;

0 commit comments

Comments
 (0)