review

Author: shortcuts

generators/src/main/java/com/algolia/codegen/AlgoliaJavascriptGenerator.java

@@ -94,10 +94,10 @@ public Map<String, Object> postProcessOperationsWithModels(
         continue;
       }
 
-      boolean hasBodyParams = ope.bodyParams.size() > 0;
-      boolean hasHeaderParams = ope.headerParams.size() > 0;
-      boolean hasQueryParams = ope.queryParams.size() > 0;
-      boolean hasPathParams = ope.pathParams.size() > 0;
+      boolean hasBodyParams = !ope.bodyParams.isEmpty();
+      boolean hasHeaderParams = !ope.headerParams.isEmpty();
+      boolean hasQueryParams = !ope.queryParams.isEmpty();
+      boolean hasPathParams = !ope.pathParams.isEmpty();
 
       // If there is nothing but body params, we just check if it's a single param
       if (

templates/javascript/api-single.mustache

@@ -198,8 +198,7 @@ export function create{{capitalizedApiName}}(options: CreateClientOptions{{#hasR
 export type {{capitalizedApiName}} = ReturnType<typeof create{{capitalizedApiName}}>;
 
 {{#operation}}
-{{#vendorExtensions}}
-  {{#x-create-wrapping-object}}
+{{#vendorExtensions.x-create-wrapping-object}}
 export type {{#lambda.titlecase}}{{nickname}}{{/lambda.titlecase}}Props = {
   {{#allParams}}
     {{#description}}
@@ -210,8 +209,7 @@ export type {{#lambda.titlecase}}{{nickname}}{{/lambda.titlecase}}Props = {
     {{paramName}}{{^required}}?{{/required}}: {{{dataType}}};
   {{/allParams}}
 }
-  {{/x-create-wrapping-object}}
-{{/vendorExtensions}}
+{{/vendorExtensions.x-create-wrapping-object}}
 
 {{/operation}}