Skip to content

Commit db35de7

Browse files
authored
fix(specs): analytics paths and params (#73)
1 parent 4e9cbcd commit db35de7

25 files changed

+157
-1209
lines changed

clients/algoliasearch-client-javascript/client-analytics/src/analyticsApi.ts

Lines changed: 56 additions & 471 deletions
Large diffs are not rendered by default.

specs/analytics/paths/common/parameters.yml

Lines changed: 3 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -7,14 +7,6 @@ Attribute:
77
schema:
88
type: string
99

10-
Search:
11-
in: path
12-
name: search
13-
description: The query term. Must match the exact user input.
14-
required: true
15-
schema:
16-
type: string
17-
1810
# query
1911
OrderBy:
2012
in: query
@@ -50,11 +42,10 @@ Limit:
5042
type: integer
5143
default: 10
5244

53-
SearchInQuery:
54-
in: path
45+
Search:
46+
in: query
5547
name: search
56-
description: The query term. Must match the exact user input.
57-
required: true
48+
description: The query term to search for. Must match the exact user input.
5849
schema:
5950
type: string
6051

specs/analytics/paths/search/getSearchAttributesTopFilters.yml

Lines changed: 0 additions & 63 deletions
This file was deleted.

specs/analytics/paths/search/getTopFilterAttributes.yml

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -6,6 +6,7 @@ get:
66
summary: Returns top filter attributes.
77
parameters:
88
- $ref: '../../../common/parameters.yml#/Index'
9+
- $ref: '../common/parameters.yml#/Search'
910
- $ref: '../../../common/parameters.yml#/StartDate'
1011
- $ref: '../../../common/parameters.yml#/EndDate'
1112
- $ref: '../common/parameters.yml#/Limit'

specs/analytics/paths/search/getTopFilterAttributesForSearch.yml

Lines changed: 0 additions & 29 deletions
This file was deleted.

specs/analytics/paths/search/getTopFilterForAttribute.yml

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -7,6 +7,7 @@ get:
77
parameters:
88
- $ref: '../common/parameters.yml#/Attribute'
99
- $ref: '../../../common/parameters.yml#/Index'
10+
- $ref: '../common/parameters.yml#/Search'
1011
- $ref: '../../../common/parameters.yml#/StartDate'
1112
- $ref: '../../../common/parameters.yml#/EndDate'
1213
- $ref: '../common/parameters.yml#/Limit'

specs/analytics/paths/search/getTopFiltersForAttributesSearch.yml

Lines changed: 0 additions & 35 deletions
This file was deleted.

specs/analytics/paths/search/getTopFiltersNoResults.yml

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -6,6 +6,7 @@ get:
66
summary: Returns top filters with no results.
77
parameters:
88
- $ref: '../../../common/parameters.yml#/Index'
9+
- $ref: '../common/parameters.yml#/Search'
910
- $ref: '../../../common/parameters.yml#/StartDate'
1011
- $ref: '../../../common/parameters.yml#/EndDate'
1112
- $ref: '../common/parameters.yml#/Limit'

specs/analytics/paths/search/getTopFiltersNoResultsForSearch.yml

Lines changed: 0 additions & 29 deletions
This file was deleted.

specs/analytics/paths/search/getTopHits.yml

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -6,6 +6,7 @@ get:
66
summary: Returns top hits.
77
parameters:
88
- $ref: '../../../common/parameters.yml#/Index'
9+
- $ref: '../common/parameters.yml#/Search'
910
- $ref: '../common/parameters.yml#/ClickAnalytics'
1011
- $ref: '../../../common/parameters.yml#/StartDate'
1112
- $ref: '../../../common/parameters.yml#/EndDate'

specs/analytics/paths/search/getTopHitsForSearch.yml

Lines changed: 0 additions & 32 deletions
This file was deleted.

specs/analytics/spec.yml

Lines changed: 0 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -30,22 +30,14 @@ paths:
3030
$ref: paths/search/getNoClickRate.yml
3131
/2/hits:
3232
$ref: paths/search/getTopHits.yml
33-
/2/hits?search={search}:
34-
$ref: paths/search/getTopHitsForSearch.yml
3533
/2/users/count:
3634
$ref: paths/search/getUsersCount.yml
3735
/2/filters:
3836
$ref: paths/search/getTopFilterAttributes.yml
3937
/2/filters/{attribute}:
4038
$ref: paths/search/getTopFilterForAttribute.yml
41-
/2/filters?search={search}:
42-
$ref: paths/search/getTopFilterAttributesForSearch.yml
4339
/2/filters/noResults:
4440
$ref: paths/search/getTopFiltersNoResults.yml
45-
/2/filters/noResults?search={search}:
46-
$ref: paths/search/getTopFiltersNoResultsForSearch.yml
47-
/2/filters/{attributes}?search={search}:
48-
$ref: paths/search/getTopFiltersForAttributesSearch.yml
4941
/2/countries:
5042
$ref: paths/search/getTopCountries.yml
5143

specs/common/parameters.yml

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -32,15 +32,17 @@ StartDate:
3232
description: The lower bound timestamp (a date, a string like "2006-01-02") of the period to analyze.
3333
schema:
3434
type: string
35-
format: date-time
35+
example: 1999-09-19
36+
pattern: ^\d{4}-(0[1-9]|1[0-2])-(0[1-9]|[12][0-9]|3[01])$
3637

3738
EndDate:
3839
in: query
3940
name: endDate
4041
description: The upper bound timestamp (a date, a string like "2006-01-02") of the period to analyze.
4142
schema:
4243
type: string
43-
format: date-time
44+
example: 2000-01-21
45+
pattern: ^\d{4}-(0[1-9]|1[0-2])-(0[1-9]|[12][0-9]|3[01])$
4446

4547
ForwardToReplicas:
4648
in: query

tests/CTS/clients/analytics/getTopFilterAttributes.json

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -15,6 +15,7 @@
1515
"testName": "get getTopFilterAttributes with all parameters",
1616
"parameters": {
1717
"index": "index",
18+
"search": "mySearch",
1819
"startDate": "1999-09-19",
1920
"endDate": "2001-01-01",
2021
"limit": 21,
@@ -26,6 +27,7 @@
2627
"method": "GET",
2728
"searchParams": {
2829
"index": "index",
30+
"search": "mySearch",
2931
"startDate": "1999-09-19",
3032
"endDate": "2001-01-01",
3133
"limit": "21",

tests/CTS/clients/analytics/getTopFilterAttributesForSearch.json

Lines changed: 0 additions & 40 deletions
This file was deleted.

0 commit comments

Comments
 (0)