review

Author: millotp

clients/algoliasearch-client-java-2/.openapi-generator-ignore

@@ -19,6 +19,7 @@ gradle*
 
 # Selective source file
 algoliasearch-core/com/algolia/auth/**
+algoliasearch-core/com/algolia/ApiException.java
 algoliasearch-core/com/algolia/Configuration.java
 algoliasearch-core/com/algolia/Server*.java
 algoliasearch-core/com/algolia/StringUtil.java

generators/src/main/java/com/algolia/codegen/AlgoliaJavaGenerator.java

@@ -168,14 +168,6 @@ public void processOpts() {
         "algoliasearch-core/com/algolia/utils/echo",
         "EchoResponse.java"));
 
-    // remove ApiException.java
-    for (int i = 0; i < supportingFiles.size(); i++) {
-      if (supportingFiles.get(i).getTemplateFile().equals("apiException.mustache")) {
-        supportingFiles.remove(i);
-        break;
-      }
-    }
-
     // Prevent all useless file to generate
     apiTestTemplateFiles.clear();
     modelTestTemplateFiles.clear();

playground/java/src/main/java/com/algolia/playground/App.java

@@ -13,22 +13,29 @@ public static void main(String[] args) {
     Dotenv dotenv = Dotenv.configure().directory("../").load();
 
     SearchApi client = new SearchApi(dotenv.get("ALGOLIA_APPLICATION_ID"), dotenv.get("ALGOLIA_SEARCH_KEY"));
+
     String indexName = dotenv.get("SEARCH_INDEX");
     SearchParamsObject params = new SearchParamsObject();
     params.setAroundRadius(AroundRadius.ofInteger(5));
     params.setQuery(dotenv.get("SEARCH_QUERY"));
+
     try {
       SearchResponse result = client.search(indexName, SearchParams.ofSearchParamsObject(params));
       System.out.println(result);
     } catch (AlgoliaApiException e) {
+      // the API failed
       System.err.println("Exception when calling SearchApi#search");
       System.err.println("Status code: " + e.getHttpErrorCode());
       System.err.println("Reason: " + e.getMessage());
       e.printStackTrace();
+
     } catch (AlgoliaRetryException e) {
+      // the retry failed
       System.err.println("Exception in the retry strategy");
       e.printStackTrace();
+
     } catch (AlgoliaRuntimeException e) {
+      // the serialization or something else failed
       e.printStackTrace();
     }
   }

templates/java/libraries/okhttp-gson/api.mustache

@@ -37,14 +37,18 @@ public class {{classname}} extends ApiClient {
     public {{classname}}(String appId, String apiKey) {
         super(appId, apiKey, new HttpRequester(getDefaultHosts(".")));
     }
+    
     {{/fallbackToAliasHost}}
     public {{classname}}(String appId, String apiKey, String region) {
         super(appId, apiKey, new HttpRequester(getDefaultHosts(region)));
     }
     {{/hasRegionalHost}}
+
+    {{^hasRegionalHost}}
     public {{classname}}(String appId, String apiKey) {
         super(appId, apiKey, new HttpRequester(getDefaultHosts(appId)));
     }
+    {{/hasRegionalHost}}
 
     public {{classname}}(String appId, String apiKey, Requester requester) {
         super(appId, apiKey, requester);