Skip to content

Commit 6077526

Browse files
JimSuplizioallenkim0129
authored andcommitted
Remove a defunct variable from docindex.yml (Azure#38342)
1 parent a0ea744 commit 6077526

File tree

7 files changed

+18
-19
lines changed

7 files changed

+18
-19
lines changed

eng/pipelines/docindex.yml

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,6 @@ jobs:
1212
DocRepoLocation: $(Pipeline.Workspace)/docs
1313
DocRepoOwner: MicrosoftDocs
1414
DocRepoName: azure-docs-sdk-python
15-
DocValidationImageId: azuresdkimages.azurecr.io/pyrefautocr:latest
1615
steps:
1716
# py2docfx requires Python >= 3.11
1817
- task: UsePythonVersion@0

sdk/cosmos/azure-cosmos/azure/cosmos/aio/_container.py

Lines changed: 11 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -22,19 +22,17 @@
2222
"""Create, read, update and delete items in the Azure Cosmos DB SQL API service.
2323
"""
2424
from datetime import datetime
25-
from typing import Any, Dict, Mapping, Optional, Sequence, Type, Union, List, Tuple, cast, overload, Iterable
25+
from typing import Any, Dict, Mapping, Optional, Sequence, Type, Union, List, Tuple, cast, overload, AsyncIterable
2626
from typing_extensions import Literal
2727

2828
from azure.core import MatchConditions
29-
from azure.core.async_paging import AsyncItemPaged
29+
from azure.core.async_paging import AsyncItemPaged, AsyncList
3030
from azure.core.tracing.decorator import distributed_trace
3131
from azure.core.tracing.decorator_async import distributed_trace_async # type: ignore
3232
from azure.cosmos._change_feed.change_feed_state import ChangeFeedMode
3333
from azure.cosmos._change_feed.change_feed_utils import validate_kwargs
3434

3535
from ._cosmos_client_connection_async import CosmosClientConnection
36-
from .._change_feed.feed_range_internal import FeedRangeInternalEpk
37-
from .._cosmos_responses import CosmosDict, CosmosList
3836
from ._scripts import ScriptsProxy
3937
from .._base import (
4038
build_options as _build_options,
@@ -44,6 +42,8 @@
4442
GenerateGuidId,
4543
_set_properties_cache
4644
)
45+
from .._change_feed.feed_range_internal import FeedRangeInternalEpk
46+
from .._cosmos_responses import CosmosDict, CosmosList
4747
from .._routing.routing_range import Range
4848
from .._session_token_helpers import get_latest_session_token
4949
from ..offer import ThroughputProperties
@@ -681,8 +681,8 @@ def query_items_change_feed( # pylint: disable=unused-argument
681681
:keyword response_hook: A callable invoked with the response metadata.
682682
:paramtype response_hook: Optional[Callable[[Mapping[str, Any], Mapping[str, Any]], None]]
683683
:param Any args: args
684-
:returns: An Iterable of items (dicts).
685-
:rtype: Iterable[Dict[str, Any]]
684+
:returns: An AsyncItemPaged of items (dicts).
685+
:rtype: AsyncItemPaged[Dict[str, Any]]
686686
"""
687687
# pylint: disable=too-many-statements
688688
validate_kwargs(kwargs)
@@ -1310,13 +1310,13 @@ async def read_feed_ranges(
13101310
*,
13111311
force_refresh: Optional[bool] = False,
13121312
**kwargs: Any
1313-
) -> Iterable[Dict[str, Any]]:
1313+
) -> AsyncIterable[Dict[str, Any]]:
13141314
""" Obtains a list of feed ranges that can be used to parallelize feed operations.
13151315
13161316
:keyword bool force_refresh:
13171317
Flag to indicate whether obtain the list of feed ranges directly from cache or refresh the cache.
1318-
:returns: A list representing the feed ranges in base64 encoded string
1319-
:rtype: Iterable[Dict[str, Any]]
1318+
:returns: AsyncIterable representing the feed ranges in base64 encoded string
1319+
:rtype: AsyncIterable[Dict[str, Any]]
13201320
13211321
.. warning::
13221322
The structure of the dict representation of a feed range may vary, including which keys
@@ -1335,7 +1335,8 @@ async def read_feed_ranges(
13351335

13361336
feed_ranges = [FeedRangeInternalEpk(Range.PartitionKeyRangeToRange(partitionKeyRange)).to_dict()
13371337
for partitionKeyRange in partition_key_ranges]
1338-
return (feed_range for feed_range in feed_ranges)
1338+
1339+
return AsyncList(feed_ranges)
13391340

13401341
async def get_latest_session_token(
13411342
self,

sdk/cosmos/azure-cosmos/azure/cosmos/container.py

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1389,9 +1389,8 @@ def read_feed_ranges(
13891389
[Range("", "FF", True, False)], # default to full range
13901390
**kwargs)
13911391

1392-
feed_ranges = [FeedRangeInternalEpk(Range.PartitionKeyRangeToRange(partitionKeyRange)).to_dict()
1392+
return [FeedRangeInternalEpk(Range.PartitionKeyRangeToRange(partitionKeyRange)).to_dict()
13931393
for partitionKeyRange in partition_key_ranges]
1394-
return (feed_range for feed_range in feed_ranges)
13951394

13961395
def get_latest_session_token(
13971396
self,

sdk/cosmos/azure-cosmos/samples/examples_async.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -265,7 +265,7 @@ async def examples_async():
265265

266266
# Get the feed ranges list from container.
267267
# [START read_feed_ranges]
268-
feed_ranges = list(await container.read_feed_ranges())
268+
feed_ranges = [feed_range async for feed_range in await container.read_feed_ranges()]
269269
# [END read_feed_ranges]
270270

271271
# Get a feed range from a partition key.
@@ -296,7 +296,7 @@ async def examples_async():
296296
# The asynchronous client returns asynchronous iterators for its query methods;
297297
# as such, we iterate over it by using an async for loop
298298
# [START query_items_change_feed_from_beginning]
299-
feed_ranges = await container.read_feed_ranges()
299+
feed_ranges = [feed_range async for feed_range in await container.read_feed_ranges()]
300300
async for item in container.query_items_change_feed(feed_range=feed_ranges[0], start_time="Beginning"):
301301
print(json.dumps(item, indent=True))
302302
# [END query_items_change_feed_from_beginning]

sdk/cosmos/azure-cosmos/samples/session_token_management_async.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -89,7 +89,7 @@ async def storing_session_tokens_container_feed_ranges(container):
8989
# to store session tokens in a cache by feed range from the partition key.
9090
feed_ranges_and_session_tokens = []
9191
previous_session_token = ""
92-
feed_ranges = list(await container.read_feed_ranges())
92+
feed_ranges = [feed_range async for feed_range in await container.read_feed_ranges()]
9393

9494
# populating cache with session tokens
9595
for i in range(5):

sdk/cosmos/azure-cosmos/test/test_change_feed_async.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -78,7 +78,7 @@ class TestChangeFeedAsync:
7878
async def test_get_feed_ranges(self, setup):
7979
created_collection = await setup["created_db"].create_container("get_feed_ranges_" + str(uuid.uuid4()),
8080
PartitionKey(path="/pk"))
81-
result = list(await created_collection.read_feed_ranges())
81+
result = [feed_range async for feed_range in await created_collection.read_feed_ranges()]
8282
assert len(result) == 1
8383

8484
@pytest.mark.parametrize("change_feed_filter_param", ["partitionKey", "partitionKeyRangeId", "feedRange"])
@@ -93,7 +93,7 @@ async def test_query_change_feed_with_different_filter_async(self, change_feed_f
9393
elif change_feed_filter_param == "partitionKeyRangeId":
9494
filter_param = {"partition_key_range_id": "0"}
9595
elif change_feed_filter_param == "feedRange":
96-
feed_ranges = list(await created_collection.read_feed_ranges())
96+
feed_ranges = [feed_range async for feed_range in await created_collection.read_feed_ranges()]
9797
assert len(feed_ranges) == 1
9898
filter_param = {"feed_range": feed_ranges[0]}
9999
else:

sdk/cosmos/azure-cosmos/test/test_latest_session_token_async.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -190,7 +190,7 @@ async def create_items_logical_pk(container, target_pk_range, previous_session_t
190190
@staticmethod
191191
async def create_items_physical_pk(container, pk_feed_range, previous_session_token, feed_ranges_and_session_tokens, hpk=False):
192192
target_session_token = ""
193-
container_feed_ranges = list(await container.read_feed_ranges())
193+
container_feed_ranges = [feed_range async for feed_range in await container.read_feed_ranges()]
194194
target_feed_range = None
195195
for feed_range in container_feed_ranges:
196196
if await container.is_feed_range_subset(feed_range, pk_feed_range):

0 commit comments

Comments
 (0)