Skip to content

Commit dd6add5

Browse files
Merge branch 'master' of https://github.com/softlayer/softlayer-python into internalAuth
2 parents 1bc264b + 6864ea2 commit dd6add5

File tree

8 files changed

+11
-29
lines changed

8 files changed

+11
-29
lines changed

.github/workflows/tests.yml

+3-3
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,7 @@ jobs:
1010
runs-on: ubuntu-latest
1111
strategy:
1212
matrix:
13-
python-version: [3.8,3.9,'3.10',3.11]
13+
python-version: [3.8,3.9,'3.10',3.11,3.12]
1414

1515
steps:
1616
- uses: actions/checkout@v4
@@ -31,7 +31,7 @@ jobs:
3131
- name: Set up Python
3232
uses: actions/setup-python@v5
3333
with:
34-
python-version: 3.11
34+
python-version: 3.12
3535
- name: Install dependencies
3636
run: |
3737
python -m pip install --upgrade pip
@@ -45,7 +45,7 @@ jobs:
4545
- name: Set up Python
4646
uses: actions/setup-python@v5
4747
with:
48-
python-version: 3.11
48+
python-version: 3.12
4949
- name: Install dependencies
5050
run: |
5151
python -m pip install --upgrade pip

SoftLayer/CLI/environment.py

+1-20
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,7 @@
1212
from json.decoder import JSONDecodeError
1313

1414
import click
15-
import pkg_resources
15+
1616
from rich.console import Console
1717
from rich.syntax import Syntax
1818

@@ -23,9 +23,6 @@
2323

2424
# pylint: disable=too-many-instance-attributes, invalid-name
2525

26-
# Calling pkg_resources.iter_entry_points shows a false-positive
27-
# pylint: disable=no-member
28-
2926

3027
class Environment(object):
3128
"""Provides access to the current CLI environment."""
@@ -165,8 +162,6 @@ def load(self):
165162

166163
self.load_modules_from_python(routes.ALL_ROUTES)
167164
self.aliases.update(routes.ALL_ALIASES)
168-
self._load_modules_from_entry_points('softlayer.cli')
169-
170165
self._modules_loaded = True
171166

172167
def load_modules_from_python(self, route_list):
@@ -178,20 +173,6 @@ def load_modules_from_python(self, route_list):
178173
path, attr = modpath, None
179174
self.commands[name] = ModuleLoader(path, attr=attr)
180175

181-
def _load_modules_from_entry_points(self, entry_point_group):
182-
"""Load modules from the entry_points (slower).
183-
184-
Entry points can be used to add new commands to the CLI.
185-
186-
Usage:
187-
188-
entry_points={'softlayer.cli': ['new-cmd = mymodule.new_cmd.cli']}
189-
190-
"""
191-
for obj in pkg_resources.iter_entry_points(group=entry_point_group,
192-
name=None):
193-
self.commands[obj.name] = obj
194-
195176
def ensure_client(self, config_file=None, is_demo=False, proxy=None):
196177
"""Create a new SLAPI client to the environment.
197178

SoftLayer/CLI/event_log/get.py

+1-1
Original file line numberDiff line numberDiff line change
@@ -76,7 +76,7 @@ def cli(env, date_min, date_max, obj_event, obj_id, obj_type, utc_offset, metada
7676
f"'{user}','{metadata_data}'")
7777
else:
7878
click.secho(f"'{log['eventName']}','{label}','{log['objectName']}',"
79-
f"'{utils.clean_time(log['eventCreateDate'],in_format=log_time)}',"
79+
f"'{utils.clean_time(log['eventCreateDate'], in_format=log_time)}',"
8080
f"'{user}'")
8181

8282
row_count = row_count + 1

SoftLayer/CLI/file/access/list.py

+1-1
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,7 @@
1515
@click.option('--sortby', help='Column to sort by', default='name')
1616
@click.option('--columns',
1717
callback=column_helper.get_formatter(storage_utils.COLUMNS),
18-
help=f"Columns to display. Options: { ', '.join(column.name for column in storage_utils.COLUMNS)}",
18+
help=f"Columns to display. Options: {', '.join(column.name for column in storage_utils.COLUMNS)}",
1919
default=','.join(storage_utils.DEFAULT_COLUMNS))
2020
@environment.pass_env
2121
def cli(env, columns, sortby, volume_id):

SoftLayer/managers/ordering.py

+1-1
Original file line numberDiff line numberDiff line change
@@ -268,7 +268,7 @@ def get_package_by_key(self, package_keyname, mask=None):
268268
"""
269269
_filter = {'keyName': {'operation': package_keyname}}
270270

271-
packages = self.package_svc.getAllObjects(mask=mask, filter=_filter)
271+
packages = self.client.call('SoftLayer_Product_Package', 'getAllObjects', mask=mask, filter=_filter)
272272
if len(packages) == 0:
273273
raise exceptions.SoftLayerError(f"Package {package_keyname} does not exist")
274274

SoftLayer/testing/xmlrpc.py

+2-2
Original file line numberDiff line numberDiff line change
@@ -17,11 +17,11 @@
1717
# pylint: disable=invalid-name, broad-except, arguments-differ
1818

1919

20-
class TestServer(http.server.HTTPServer):
20+
class TestServer(http.server.ThreadingHTTPServer):
2121
"""Test HTTP server which holds a given transport."""
2222

2323
def __init__(self, transport, *args, **kw):
24-
http.server.HTTPServer.__init__(self, *args, **kw)
24+
http.server.ThreadingHTTPServer.__init__(self, *args, **kw)
2525
self.transport = transport
2626

2727

setup.py

+1
Original file line numberDiff line numberDiff line change
@@ -56,6 +56,7 @@
5656
'Programming Language :: Python :: 3.9',
5757
'Programming Language :: Python :: 3.10',
5858
'Programming Language :: Python :: 3.11',
59+
'Programming Language :: Python :: 3.12',
5960
'Programming Language :: Python :: Implementation :: CPython',
6061
'Programming Language :: Python :: Implementation :: PyPy',
6162
],

tox.ini

+1-1
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
[tox]
2-
envlist = py37,py38,py39,py310,py311,pypy3,analysis,coverage,docs
2+
envlist = py38,py39,py310,py311,py312,pypy3,analysis,coverage,docs
33

44

55
[flake8]

0 commit comments

Comments
 (0)