Skip to content

llama: why is input_prefix_bos user-provided in main example? #13

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
iboB opened this issue Jul 17, 2024 · 4 comments
Closed

llama: why is input_prefix_bos user-provided in main example? #13

iboB opened this issue Jul 17, 2024 · 4 comments
Assignees
Labels
good first issue Good for newcomers

Comments

@iboB
Copy link
Member

iboB commented Jul 17, 2024

Find out the significance of this. For now we're ignoring this. Maybe we will have to add it

@iboB iboB added the question Further information is requested label Jul 17, 2024
@iboB iboB added the good first issue Good for newcomers label Jul 29, 2024
@pminev
Copy link
Contributor

pminev commented Aug 15, 2024

input_prefix_bos was added in this PR . It seems like it was needed for llama-2-chat prompt format. If we're going to support it, I think we'll need it.

Basically we can deduct that if client will want chat we can pass the BOS before adding the input prefix, so we can hide it from the clients.

@IvanFilipov
Copy link
Contributor

Maybe with the investigation completed, we can close this issue.
With little to no context, as far as I understand we need a new working item - to add the support.

In general, may I suggest that we add a hyperlink to each abbreviation,
which doesn't pop up as a first google search result.
In my opinion, getting contributors up to speed on a topic, will be much easier that way.

@iboB
Copy link
Member Author

iboB commented Aug 29, 2024

Still not clear if there's something actionable to be done on our part

@iboB iboB added i:llama and removed question Further information is requested labels Oct 2, 2024
@iboB
Copy link
Member Author

iboB commented Oct 4, 2024

I wouldn't call this completed, but we'll reintroduce the option just in case

@iboB iboB closed this as completed in efac029 Oct 4, 2024
@github-project-automation github-project-automation bot moved this from In Progress to Done in Local SDK MVP Oct 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers
Projects
No open projects
Status: Done
Development

No branches or pull requests

3 participants