Use a trivial solution to prometheus#1605

krajorama · amberpixels · commit d31ec24047e7 · 2024-11-29T11:30:45.000+02:00
Signed-off-by: György Krajcsovits &lt;gyorgy.krajcsovits@grafana.com&gt;
Signed-off-by: Eugene &lt;eugene@amberpixels.io&gt;
diff --git a/prometheus/histogram.go b/prometheus/histogram.go
@@ -1682,13 +1682,13 @@ func makeNativeExemplars(ttl time.Duration, maxCount int) nativeExemplars {
 }
 
 func (n *nativeExemplars) addExemplar(e *dto.Exemplar) {
+	n.Lock()
+	defer n.Unlock()
+
 	if cap(n.exemplars) == 0 {
 		return
 	}
 
-	n.Lock()
-	defer n.Unlock()
-
 	// The index where to insert the new exemplar.
 	var nIdx int = -1
 

Original file line number	Diff line number	Diff line change
`@@ -1682,13 +1682,13 @@ func makeNativeExemplars(ttl time.Duration, maxCount int) nativeExemplars {`
`1682`	`1682`	`}`
`1683`	`1683`
`1684`	`1684`	`func (n nativeExemplars) addExemplar(e dto.Exemplar) {`
	`1685`	`+ n.Lock()`
	`1686`	`+ defer n.Unlock()`
	`1687`	`+`
`1685`	`1688`	`if cap(n.exemplars) == 0 {`
`1686`	`1689`	`return`
`1687`	`1690`	`}`
`1688`	`1691`
`1689`		`- n.Lock()`
`1690`		`- defer n.Unlock()`
`1691`		`-`
`1692`	`1692`	`// The index where to insert the new exemplar.`
`1693`	`1693`	`var nIdx int = -1`
`1694`	`1694`