Skip to content

Commit 0858c2e

Browse files
Log Successful Snapshot Abort (elastic#62707)
We were missing a log statement for snapshots that could be aborted directly due to the optimization in elastic#62173. Without logging added we get no logging whatsoever and snapshots disappear without anything logged at info level which makes debugging unnecessarily complex.
1 parent 27ca0a8 commit 0858c2e

File tree

1 file changed

+3
-0
lines changed

1 file changed

+3
-0
lines changed

server/src/main/java/org/elasticsearch/snapshots/SnapshotsService.java

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1248,6 +1248,9 @@ public void onFailure(String source, Exception e) {
12481248

12491249
@Override
12501250
public void clusterStateProcessed(String source, ClusterState oldState, ClusterState newState) {
1251+
if (completedNoCleanup.isEmpty() == false) {
1252+
logger.info("snapshots {} aborted", completedNoCleanup);
1253+
}
12511254
for (Snapshot snapshot : completedNoCleanup) {
12521255
failSnapshotCompletionListeners(snapshot,
12531256
new SnapshotException(snapshot, SnapshotsInProgress.ABORTED_FAILURE_TEXT));

0 commit comments

Comments
 (0)