Skip to content

Commit ccaba01

Browse files
authored
Fix task ordering in rolling upgrade tests
The configuration of the upgraded cluster task was missing a dependency on the stopping of the second old node in the cluster. In some cases (e.g., --parallel) Gradle would then try to run the configuration of a node in the upgraded cluster before it had even configured the old nodes in the cluster. Relates elastic#28036
1 parent 8ceae2a commit ccaba01

File tree

1 file changed

+2
-3
lines changed

1 file changed

+2
-3
lines changed

qa/rolling-upgrade/build.gradle

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -74,11 +74,10 @@ for (Version version : versionCollection.versionsWireCompatibleWithCurrent) {
7474
finalizedBy "${baseName}#oldClusterTestCluster#node0.stop"
7575
}
7676

77-
Task upgradedClusterTest = tasks.create(name: "${baseName}#upgradedClusterTest", type: RestIntegTestTask) {
78-
dependsOn(mixedClusterTestRunner, "${baseName}#oldClusterTestCluster#node0.stop")
79-
}
77+
Task upgradedClusterTest = tasks.create(name: "${baseName}#upgradedClusterTest", type: RestIntegTestTask)
8078

8179
configure(extensions.findByName("${baseName}#upgradedClusterTestCluster")) {
80+
dependsOn mixedClusterTestRunner, "${baseName}#oldClusterTestCluster#node0.stop"
8281
distribution = 'zip'
8382
clusterName = 'rolling-upgrade'
8483
unicastTransportUri = { seedNode, node, ant -> mixedClusterTest.nodes.get(0).transportUri() }

0 commit comments

Comments
 (0)