Skip to content
This repository was archived by the owner on May 29, 2019. It is now read-only.

Commit 1f760eb

Browse files
Armin Cifuenteswesleycho
Armin Cifuentes
authored andcommitted
feat(timepicker): add showSpinner flag
- Add optional `showSpinner` flag support
1 parent d631af5 commit 1f760eb

File tree

3 files changed

+34
-26
lines changed

3 files changed

+34
-26
lines changed

src/timepicker/docs/readme.md

+4
Original file line numberDiff line numberDiff line change
@@ -35,3 +35,7 @@ All settings can be provided as attributes in the `<timepicker>` or globally con
3535
* `arrowkeys`
3636
_(Defaults: true)_ :
3737
Whether user can use up/down arrowkeys inside the hours & minutes input to increase or decrease it's values.
38+
39+
* `show-spinners`
40+
_(Defaults: true)_ :
41+
Shows spinner arrows above and below the inputs

src/timepicker/timepicker.js

+6-2
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,8 @@ angular.module('ui.bootstrap.timepicker', [])
77
meridians: null,
88
readonlyInput: false,
99
mousewheel: true,
10-
arrowkeys: true
10+
arrowkeys: true,
11+
showSpinners: true
1112
})
1213

1314
.controller('TimepickerController', ['$scope', '$attrs', '$parse', '$log', '$locale', 'timepickerConfig', function($scope, $attrs, $parse, $log, $locale, timepickerConfig) {
@@ -258,7 +259,10 @@ angular.module('ui.bootstrap.timepicker', [])
258259
selected.setHours( dt.getHours(), dt.getMinutes() );
259260
refresh();
260261
}
261-
262+
263+
$scope.showSpinners = angular.isDefined($attrs.showSpinners) ?
264+
$scope.$parent.$eval($attrs.showSpinners) : timepickerConfig.showSpinners;
265+
262266
$scope.incrementHours = function() {
263267
addMinutes( hourStep * 60 );
264268
};

template/timepicker/timepicker.html

+24-24
Original file line numberDiff line numberDiff line change
@@ -1,26 +1,26 @@
11
<table>
2-
<tbody>
3-
<tr class="text-center">
4-
<td><a ng-click="incrementHours()" class="btn btn-link"><span class="glyphicon glyphicon-chevron-up"></span></a></td>
5-
<td>&nbsp;</td>
6-
<td><a ng-click="incrementMinutes()" class="btn btn-link"><span class="glyphicon glyphicon-chevron-up"></span></a></td>
7-
<td ng-show="showMeridian"></td>
8-
</tr>
9-
<tr>
10-
<td class="form-group" ng-class="{'has-error': invalidHours}">
11-
<input style="width:50px;" type="text" ng-model="hours" ng-change="updateHours()" class="form-control text-center" ng-readonly="readonlyInput" maxlength="2">
12-
</td>
13-
<td>:</td>
14-
<td class="form-group" ng-class="{'has-error': invalidMinutes}">
15-
<input style="width:50px;" type="text" ng-model="minutes" ng-change="updateMinutes()" class="form-control text-center" ng-readonly="readonlyInput" maxlength="2">
16-
</td>
17-
<td ng-show="showMeridian"><button type="button" class="btn btn-default text-center" ng-click="toggleMeridian()">{{meridian}}</button></td>
18-
</tr>
19-
<tr class="text-center">
20-
<td><a ng-click="decrementHours()" class="btn btn-link"><span class="glyphicon glyphicon-chevron-down"></span></a></td>
21-
<td>&nbsp;</td>
22-
<td><a ng-click="decrementMinutes()" class="btn btn-link"><span class="glyphicon glyphicon-chevron-down"></span></a></td>
23-
<td ng-show="showMeridian"></td>
24-
</tr>
25-
</tbody>
2+
<tbody>
3+
<tr class="text-center" ng-show="showSpinners">
4+
<td><a ng-click="incrementHours()" class="btn btn-link"><span class="glyphicon glyphicon-chevron-up"></span></a></td>
5+
<td>&nbsp;</td>
6+
<td><a ng-click="incrementMinutes()" class="btn btn-link"><span class="glyphicon glyphicon-chevron-up"></span></a></td>
7+
<td ng-show="showMeridian"></td>
8+
</tr>
9+
<tr>
10+
<td class="form-group" ng-class="{'has-error': invalidHours}">
11+
<input style="width:50px;" type="text" ng-model="hours" ng-change="updateHours()" class="form-control text-center" ng-readonly="readonlyInput" maxlength="2">
12+
</td>
13+
<td>:</td>
14+
<td class="form-group" ng-class="{'has-error': invalidMinutes}">
15+
<input style="width:50px;" type="text" ng-model="minutes" ng-change="updateMinutes()" class="form-control text-center" ng-readonly="readonlyInput" maxlength="2">
16+
</td>
17+
<td ng-show="showMeridian"><button type="button" class="btn btn-default text-center" ng-click="toggleMeridian()">{{meridian}}</button></td>
18+
</tr>
19+
<tr class="text-center" ng-show="::showSpinners">
20+
<td><a ng-click="decrementHours()" class="btn btn-link"><span class="glyphicon glyphicon-chevron-down"></span></a></td>
21+
<td>&nbsp;</td>
22+
<td><a ng-click="decrementMinutes()" class="btn btn-link"><span class="glyphicon glyphicon-chevron-down"></span></a></td>
23+
<td ng-show="showMeridian"></td>
24+
</tr>
25+
</tbody>
2626
</table>

0 commit comments

Comments
 (0)