Skip to content
This repository was archived by the owner on May 29, 2019. It is now read-only.

Commit 5f4eedd

Browse files
committed
feat(accordion): add appropriate tabindex on disabled
- Add `tabindex="-1"` to accordion group header when disabled and remove when not to assist with accessibility Closes #4067 Closes #5990
1 parent 96d52ce commit 5f4eedd

File tree

3 files changed

+3
-2
lines changed

3 files changed

+3
-2
lines changed

src/accordion/accordion.js

+1-1
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
angular.module('ui.bootstrap.accordion', ['ui.bootstrap.collapse'])
1+
angular.module('ui.bootstrap.accordion', ['ui.bootstrap.collapse', 'ui.bootstrap.tabindex'])
22

33
.constant('uibAccordionConfig', {
44
closeOthers: true

src/accordion/index.js

+1
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,5 @@
11
require('../collapse');
2+
require('../tabindex');
23
require('../../template/accordion/accordion-group.html.js');
34
require('../../template/accordion/accordion.html.js');
45
require('./accordion');

template/accordion/accordion-group.html

+1-1
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
<div role="tab" id="{{::headingId}}" aria-selected="{{isOpen}}" class="panel-heading" ng-keypress="toggleOpen($event)">
22
<h4 class="panel-title">
3-
<a role="button" data-toggle="collapse" href aria-expanded="{{isOpen}}" aria-controls="{{::panelId}}" tabindex="0" class="accordion-toggle" ng-click="toggleOpen()" uib-accordion-transclude="heading"><span uib-accordion-header ng-class="{'text-muted': isDisabled}">{{heading}}</span></a>
3+
<a role="button" data-toggle="collapse" href aria-expanded="{{isOpen}}" aria-controls="{{::panelId}}" tabindex="0" class="accordion-toggle" ng-click="toggleOpen()" uib-accordion-transclude="heading" ng-disabled="isDisabled" uib-tabindex-toggle><span uib-accordion-header ng-class="{'text-muted': isDisabled}">{{heading}}</span></a>
44
</h4>
55
</div>
66
<div id="{{::panelId}}" aria-labelledby="{{::headingId}}" aria-hidden="{{!isOpen}}" role="tabpanel" class="panel-collapse collapse" uib-collapse="!isOpen">

0 commit comments

Comments
 (0)