fix(modal): controllerAs not checked

aeharding · pkozlowski-opensource · commit 7b7cdf842278 · 2014-08-15T18:04:05.000+02:00
This causes the controller to be added to the scope as a property "undefined"! Closes #2564
diff --git a/src/modal/modal.js b/src/modal/modal.js
@@ -377,7 +377,7 @@ angular.module('ui.bootstrap.modal', ['ui.bootstrap.transition'])
                 });
 
                 ctrlInstance = $controller(modalOptions.controller, ctrlLocals);
-                if (modalOptions.controller) {
+                if (modalOptions.controllerAs) {
                   modalScope[modalOptions.controllerAs] = ctrlInstance;
                 }
               }

Original file line number	Diff line number	Diff line change
`@@ -377,7 +377,7 @@ angular.module('ui.bootstrap.modal', ['ui.bootstrap.transition'])`
`377`	`377`	`});`
`378`	`378`
`379`	`379`	`ctrlInstance = $controller(modalOptions.controller, ctrlLocals);`
`380`		`- if (modalOptions.controller) {`
	`380`	`+ if (modalOptions.controllerAs) {`
`381`	`381`	`modalScope[modalOptions.controllerAs] = ctrlInstance;`
`382`	`382`	`}`
`383`	`383`	`}`