Skip to content
This repository was archived by the owner on May 29, 2019. It is now read-only.

Commit 8074899

Browse files
Wei Wangwesleycho
Wei Wang
authored andcommitted
fix: modify CSS loaded for modules with dependencies
- Modify loading of CSS to be purely in the index.js files for modules that depend on other modules with CSS files Closes #5698
1 parent e50f602 commit 8074899

File tree

11 files changed

+33
-23
lines changed

11 files changed

+33
-23
lines changed

README.md

+2
Original file line numberDiff line numberDiff line change
@@ -117,6 +117,8 @@ If you would prefer not to load your css through your JavaScript file loader/bun
117117
* carousel
118118
* datepicker
119119
* datepickerPopup
120+
* dropdown
121+
* popover
120122
* position
121123
* timepicker
122124
* tooltip

src/datepickerPopup/index-nocss.js

+2-2
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
1-
require('../datepicker');
2-
require('../position');
1+
require('../datepicker/index-nocss.js');
2+
require('../position/index-nocss.js');
33
require('../../template/datepickerPopup/popup.html.js');
44

55
var MODULE_NAME = 'ui.bootstrap.module.datepickerPopup';

src/datepickerPopup/index.js

+2
Original file line numberDiff line numberDiff line change
@@ -1,2 +1,4 @@
1+
require('../datepicker/datepicker.css');
2+
require('../position/position.css');
13
require('./popup.css');
24
module.exports = require('./index-nocss.js');

src/dropdown/index-nocss.js

+8
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,8 @@
1+
require('../position/index-nocss.js');
2+
require('./dropdown');
3+
4+
var MODULE_NAME = 'ui.bootstrap.module.dropdown';
5+
6+
angular.module(MODULE_NAME, ['ui.bootstrap.dropdown']);
7+
8+
module.exports = MODULE_NAME;

src/dropdown/index.js

+2-8
Original file line numberDiff line numberDiff line change
@@ -1,8 +1,2 @@
1-
require('../position');
2-
require('./dropdown');
3-
4-
var MODULE_NAME = 'ui.bootstrap.module.dropdown';
5-
6-
angular.module(MODULE_NAME, ['ui.bootstrap.dropdown']);
7-
8-
module.exports = MODULE_NAME;
1+
require('../position/position.css');
2+
module.exports = require('./index-nocss.js');

src/popover/index-nocss.js

+11
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,11 @@
1+
require('../tooltip/index-nocss.js');
2+
require('../../template/popover/popover.html.js');
3+
require('../../template/popover/popover-html.html.js');
4+
require('../../template/popover/popover-template.html.js');
5+
require('./popover');
6+
7+
var MODULE_NAME = 'ui.bootstrap.module.popover';
8+
9+
angular.module(MODULE_NAME, ['ui.bootstrap.popover', 'uib/template/popover/popover.html', 'uib/template/popover/popover-html.html', 'uib/template/popover/popover-template.html']);
10+
11+
module.exports = MODULE_NAME;

src/popover/index.js

+2-11
Original file line numberDiff line numberDiff line change
@@ -1,11 +1,2 @@
1-
require('../tooltip');
2-
require('../../template/popover/popover.html.js');
3-
require('../../template/popover/popover-html.html.js');
4-
require('../../template/popover/popover-template.html.js');
5-
require('./popover');
6-
7-
var MODULE_NAME = 'ui.bootstrap.module.popover';
8-
9-
angular.module(MODULE_NAME, ['ui.bootstrap.popover', 'uib/template/popover/popover.html', 'uib/template/popover/popover-html.html', 'uib/template/popover/popover-template.html']);
10-
11-
module.exports = MODULE_NAME;
1+
require('../tooltip/tooltip.css');
2+
module.exports = require('./index-nocss.js');

src/tooltip/index-nocss.js

+1-1
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
require('../position');
1+
require('../position/index-nocss.js');
22
require('../stackedMap');
33
require('../../template/tooltip/tooltip-popup.html.js');
44
require('../../template/tooltip/tooltip-html-popup.html.js');

src/tooltip/index.js

+1
Original file line numberDiff line numberDiff line change
@@ -1,2 +1,3 @@
1+
require('../position/position.css');
12
require('./tooltip.css');
23
module.exports = require('./index-nocss.js');

src/typeahead/index-nocss.js

+1-1
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
require('../debounce');
2-
require('../position');
2+
require('../position/index-nocss.js');
33
require('../../template/typeahead/typeahead-match.html.js');
44
require('../../template/typeahead/typeahead-popup.html.js');
55
require('./typeahead');

src/typeahead/index.js

+1
Original file line numberDiff line numberDiff line change
@@ -1,2 +1,3 @@
1+
require('../position/position.css');
12
require('./typeahead.css');
23
module.exports = require('./index-nocss.js');

0 commit comments

Comments
 (0)