Skip to content
This repository was archived by the owner on May 29, 2019. It is now read-only.

Commit 87fc242

Browse files
wesleychowesleycho
committed
feat(timepicker): add documentation for max/min
- Add documentation on new max/min attributes - Fix code style
1 parent 6c0010b commit 87fc242

File tree

3 files changed

+72
-59
lines changed

3 files changed

+72
-59
lines changed

‎src/timepicker/docs/readme.md

+8
Original file line numberDiff line numberDiff line change
@@ -39,3 +39,11 @@ All settings can be provided as attributes in the `<timepicker>` or globally con
3939
* `show-spinners`
4040
_(Defaults: true)_ :
4141
Shows spinner arrows above and below the inputs
42+
43+
* `min`
44+
_(Defaults: undefined)_ :
45+
Minimum time a user can select
46+
47+
* `max`
48+
_(Defaults: undefined)_ :
49+
Maximum time a user can select

‎src/timepicker/test/timepicker.spec.js

+39-39
Original file line numberDiff line numberDiff line change
@@ -1009,7 +1009,7 @@ describe('timepicker directive', function () {
10091009
beforeEach(inject(function($sniffer) {
10101010
element = $compile('<timepicker ng-model="time" min="min"></timepicker>')($rootScope);
10111011
$rootScope.$digest();
1012-
changeInputValueTo = function (inputEl, value) {
1012+
changeInputValueTo = function(inputEl, value) {
10131013
inputEl.val(value);
10141014
inputEl.trigger($sniffer.hasEvent('input') ? 'input' : 'change');
10151015
$rootScope.$digest();
@@ -1059,12 +1059,12 @@ describe('timepicker directive', function () {
10591059
expect(getTimeState()).toEqual(['01', '40', 'PM']);
10601060
expect(getModelState()).toEqual([13, 40]);
10611061

1062-
hoursEl.trigger( downMouseWheelEvent );
1062+
hoursEl.trigger(downMouseWheelEvent);
10631063
$rootScope.$digest();
10641064
expect(getTimeState()).toEqual(['12', '40', 'PM']);
10651065
expect(getModelState()).toEqual([12, 40]);
10661066

1067-
hoursEl.trigger( downKeydownEvent );
1067+
hoursEl.trigger(downKeydownEvent);
10681068
$rootScope.$digest();
10691069
expect(getTimeState()).toEqual(['11', '40', 'AM']);
10701070
expect(getModelState()).toEqual([11, 40]);
@@ -1073,7 +1073,7 @@ describe('timepicker directive', function () {
10731073
it('should not decrease minutes when it would result in a time ealier than min', function() {
10741074
var down = getMinutesButton(false);
10751075
var inputs = element.find('input');
1076-
var minutessEl = inputs.eq(1);
1076+
var minutesEl = inputs.eq(1);
10771077
var downMouseWheelEvent = wheelThatMouse(-1);
10781078
var downKeydownEvent = keydown('down');
10791079

@@ -1086,12 +1086,12 @@ describe('timepicker directive', function () {
10861086
expect(getTimeState()).toEqual(['02', '40', 'PM']);
10871087
expect(getModelState()).toEqual([14, 40]);
10881088

1089-
minutessEl.trigger( downMouseWheelEvent );
1089+
minutesEl.trigger(downMouseWheelEvent);
10901090
$rootScope.$digest();
10911091
expect(getTimeState()).toEqual(['02', '40', 'PM']);
10921092
expect(getModelState()).toEqual([14, 40]);
10931093

1094-
minutessEl.trigger( downKeydownEvent );
1094+
minutesEl.trigger(downKeydownEvent);
10951095
$rootScope.$digest();
10961096
expect(getTimeState()).toEqual(['02', '40', 'PM']);
10971097
expect(getModelState()).toEqual([14, 40]);
@@ -1100,7 +1100,7 @@ describe('timepicker directive', function () {
11001100
it('should decrease minutes when it would not result in a time ealier than min', function() {
11011101
var down = getMinutesButton(false);
11021102
var inputs = element.find('input');
1103-
var minutessEl = inputs.eq(1);
1103+
var minutesEl = inputs.eq(1);
11041104
var downMouseWheelEvent = wheelThatMouse(-1);
11051105
var downKeydownEvent = keydown('down');
11061106

@@ -1113,12 +1113,12 @@ describe('timepicker directive', function () {
11131113
expect(getTimeState()).toEqual(['02', '39', 'PM']);
11141114
expect(getModelState()).toEqual([14, 39]);
11151115

1116-
minutessEl.trigger( downMouseWheelEvent );
1116+
minutesEl.trigger(downMouseWheelEvent);
11171117
$rootScope.$digest();
11181118
expect(getTimeState()).toEqual(['02', '38', 'PM']);
11191119
expect(getModelState()).toEqual([14, 38]);
11201120

1121-
minutessEl.trigger( downKeydownEvent );
1121+
minutesEl.trigger(downKeydownEvent);
11221122
$rootScope.$digest();
11231123
expect(getTimeState()).toEqual(['02', '37', 'PM']);
11241124
expect(getModelState()).toEqual([14, 37]);
@@ -1141,12 +1141,12 @@ describe('timepicker directive', function () {
11411141
expect(getTimeState()).toEqual(['11', '59', 'PM']);
11421142
expect(getModelState()).toEqual([23, 59]);
11431143

1144-
hoursEl.trigger( upMouseWheelEvent );
1144+
hoursEl.trigger(upMouseWheelEvent);
11451145
$rootScope.$digest();
11461146
expect(getTimeState()).toEqual(['11', '59', 'PM']);
11471147
expect(getModelState()).toEqual([23, 59]);
11481148

1149-
hoursEl.trigger( upKeydownEvent );
1149+
hoursEl.trigger(upKeydownEvent);
11501150
$rootScope.$digest();
11511151
expect(getTimeState()).toEqual(['11', '59', 'PM']);
11521152
expect(getModelState()).toEqual([23, 59]);
@@ -1173,15 +1173,15 @@ describe('timepicker directive', function () {
11731173
$rootScope.time = newTime(23, 59);
11741174
$rootScope.$digest();
11751175

1176-
hoursEl.trigger( upMouseWheelEvent );
1176+
hoursEl.trigger(upMouseWheelEvent);
11771177
$rootScope.$digest();
11781178
expect(getTimeState()).toEqual(['12', '59', 'AM']);
11791179
expect(getModelState()).toEqual([0, 59]);
11801180

11811181
$rootScope.time = newTime(23, 59);
11821182
$rootScope.$digest();
11831183

1184-
hoursEl.trigger( upKeydownEvent );
1184+
hoursEl.trigger(upKeydownEvent);
11851185
$rootScope.$digest();
11861186
expect(getTimeState()).toEqual(['12', '59', 'AM']);
11871187
expect(getModelState()).toEqual([0, 59]);
@@ -1191,7 +1191,7 @@ describe('timepicker directive', function () {
11911191
it('should not increase minutes when time would rollover to a time earlier than min', function() {
11921192
var up = getMinutesButton(true);
11931193
var inputs = element.find('input');
1194-
var minutessEl = inputs.eq(1);
1194+
var minutesEl = inputs.eq(1);
11951195
var upMouseWheelEvent = wheelThatMouse(1);
11961196
var upKeydownEvent = keydown('up');
11971197

@@ -1205,12 +1205,12 @@ describe('timepicker directive', function () {
12051205
expect(getTimeState()).toEqual(['11', '59', 'PM']);
12061206
expect(getModelState()).toEqual([23, 59]);
12071207

1208-
minutessEl.trigger( upMouseWheelEvent );
1208+
minutesEl.trigger(upMouseWheelEvent);
12091209
$rootScope.$digest();
12101210
expect(getTimeState()).toEqual(['11', '59', 'PM']);
12111211
expect(getModelState()).toEqual([23, 59]);
12121212

1213-
minutessEl.trigger( upKeydownEvent );
1213+
minutesEl.trigger(upKeydownEvent);
12141214
$rootScope.$digest();
12151215
expect(getTimeState()).toEqual(['11', '59', 'PM']);
12161216
expect(getModelState()).toEqual([23, 59]);
@@ -1219,7 +1219,7 @@ describe('timepicker directive', function () {
12191219
it('should increase minutes when time would rollover to a time not earlier than min', function() {
12201220
var up = getMinutesButton(true);
12211221
var inputs = element.find('input');
1222-
var minutessEl = inputs.eq(1);
1222+
var minutesEl = inputs.eq(1);
12231223
var upMouseWheelEvent = wheelThatMouse(1);
12241224
var upKeydownEvent = keydown('up');
12251225

@@ -1237,15 +1237,15 @@ describe('timepicker directive', function () {
12371237
$rootScope.time = newTime(23, 59);
12381238
$rootScope.$digest();
12391239

1240-
minutessEl.trigger( upMouseWheelEvent );
1240+
minutesEl.trigger(upMouseWheelEvent);
12411241
$rootScope.$digest();
12421242
expect(getTimeState()).toEqual(['12', '00', 'AM']);
12431243
expect(getModelState()).toEqual([0, 0]);
12441244

12451245
$rootScope.time = newTime(23, 59);
12461246
$rootScope.$digest();
12471247

1248-
minutessEl.trigger( upKeydownEvent );
1248+
minutesEl.trigger(upKeydownEvent);
12491249
$rootScope.$digest();
12501250
expect(getTimeState()).toEqual(['12', '00', 'AM']);
12511251
expect(getModelState()).toEqual([0, 0]);
@@ -1360,12 +1360,12 @@ describe('timepicker directive', function () {
13601360
expect(getTimeState()).toEqual(['02', '40', 'PM']);
13611361
expect(getModelState()).toEqual([14, 40]);
13621362

1363-
hoursEl.trigger( upMouseWheelEvent );
1363+
hoursEl.trigger(upMouseWheelEvent);
13641364
$rootScope.$digest();
13651365
expect(getTimeState()).toEqual(['02', '40', 'PM']);
13661366
expect(getModelState()).toEqual([14, 40]);
13671367

1368-
hoursEl.trigger( upKeydownEvent );
1368+
hoursEl.trigger(upKeydownEvent);
13691369
$rootScope.$digest();
13701370
expect(getTimeState()).toEqual(['02', '40', 'PM']);
13711371
expect(getModelState()).toEqual([14, 40]);
@@ -1387,12 +1387,12 @@ describe('timepicker directive', function () {
13871387
expect(getTimeState()).toEqual(['03', '40', 'PM']);
13881388
expect(getModelState()).toEqual([15, 40]);
13891389

1390-
hoursEl.trigger( upMouseWheelEvent );
1390+
hoursEl.trigger(upMouseWheelEvent);
13911391
$rootScope.$digest();
13921392
expect(getTimeState()).toEqual(['04', '40', 'PM']);
13931393
expect(getModelState()).toEqual([16, 40]);
13941394

1395-
hoursEl.trigger( upKeydownEvent );
1395+
hoursEl.trigger(upKeydownEvent);
13961396
$rootScope.$digest();
13971397
expect(getTimeState()).toEqual(['05', '40', 'PM']);
13981398
expect(getModelState()).toEqual([17, 40]);
@@ -1401,7 +1401,7 @@ describe('timepicker directive', function () {
14011401
it('should not increase minutes when it would result in a time later than max', function() {
14021402
var up = getMinutesButton(true);
14031403
var inputs = element.find('input');
1404-
var minutessEl = inputs.eq(1);
1404+
var minutesEl = inputs.eq(1);
14051405
var upMouseWheelEvent = wheelThatMouse(1);
14061406
var upKeydownEvent = keydown('up');
14071407

@@ -1414,12 +1414,12 @@ describe('timepicker directive', function () {
14141414
expect(getTimeState()).toEqual(['02', '40', 'PM']);
14151415
expect(getModelState()).toEqual([14, 40]);
14161416

1417-
minutessEl.trigger( upMouseWheelEvent );
1417+
minutesEl.trigger(upMouseWheelEvent);
14181418
$rootScope.$digest();
14191419
expect(getTimeState()).toEqual(['02', '40', 'PM']);
14201420
expect(getModelState()).toEqual([14, 40]);
14211421

1422-
minutessEl.trigger( upKeydownEvent );
1422+
minutesEl.trigger(upKeydownEvent);
14231423
$rootScope.$digest();
14241424
expect(getTimeState()).toEqual(['02', '40', 'PM']);
14251425
expect(getModelState()).toEqual([14, 40]);
@@ -1428,7 +1428,7 @@ describe('timepicker directive', function () {
14281428
it('should increase minutes when it would not result in a time later than max', function() {
14291429
var up = getMinutesButton(true);
14301430
var inputs = element.find('input');
1431-
var minutessEl = inputs.eq(1);
1431+
var minutesEl = inputs.eq(1);
14321432
var upMouseWheelEvent = wheelThatMouse(1);
14331433
var upKeydownEvent = keydown('up');
14341434

@@ -1441,12 +1441,12 @@ describe('timepicker directive', function () {
14411441
expect(getTimeState()).toEqual(['02', '41', 'PM']);
14421442
expect(getModelState()).toEqual([14, 41]);
14431443

1444-
minutessEl.trigger( upMouseWheelEvent );
1444+
minutesEl.trigger(upMouseWheelEvent);
14451445
$rootScope.$digest();
14461446
expect(getTimeState()).toEqual(['02', '42', 'PM']);
14471447
expect(getModelState()).toEqual([14, 42]);
14481448

1449-
minutessEl.trigger( upKeydownEvent );
1449+
minutesEl.trigger(upKeydownEvent);
14501450
$rootScope.$digest();
14511451
expect(getTimeState()).toEqual(['02', '43', 'PM']);
14521452
expect(getModelState()).toEqual([14, 43]);
@@ -1469,12 +1469,12 @@ describe('timepicker directive', function () {
14691469
expect(getTimeState()).toEqual(['12', '00', 'AM']);
14701470
expect(getModelState()).toEqual([0, 0]);
14711471

1472-
hoursEl.trigger( downMouseWheelEvent );
1472+
hoursEl.trigger(downMouseWheelEvent);
14731473
$rootScope.$digest();
14741474
expect(getTimeState()).toEqual(['12', '00', 'AM']);
14751475
expect(getModelState()).toEqual([0, 0]);
14761476

1477-
hoursEl.trigger( downKeydownEvent );
1477+
hoursEl.trigger(downKeydownEvent);
14781478
$rootScope.$digest();
14791479
expect(getTimeState()).toEqual(['12', '00', 'AM']);
14801480
expect(getModelState()).toEqual([0, 0]);
@@ -1501,15 +1501,15 @@ describe('timepicker directive', function () {
15011501
$rootScope.time = newTime(0, 0);
15021502
$rootScope.$digest();
15031503

1504-
hoursEl.trigger( downMouseWheelEvent );
1504+
hoursEl.trigger(downMouseWheelEvent);
15051505
$rootScope.$digest();
15061506
expect(getTimeState()).toEqual(['11', '00', 'PM']);
15071507
expect(getModelState()).toEqual([23, 0]);
15081508

15091509
$rootScope.time = newTime(0, 0);
15101510
$rootScope.$digest();
15111511

1512-
hoursEl.trigger( downKeydownEvent );
1512+
hoursEl.trigger(downKeydownEvent);
15131513
$rootScope.$digest();
15141514
expect(getTimeState()).toEqual(['11', '00', 'PM']);
15151515
expect(getModelState()).toEqual([23, 0]);
@@ -1518,7 +1518,7 @@ describe('timepicker directive', function () {
15181518
it('should not decrease minutes when time would rollover to a time later than max', function() {
15191519
var down = getMinutesButton(false);
15201520
var inputs = element.find('input');
1521-
var minutessEl = inputs.eq(1);
1521+
var minutesEl = inputs.eq(1);
15221522
var downMouseWheelEvent = wheelThatMouse(-1);
15231523
var downKeydownEvent = keydown('down');
15241524

@@ -1532,12 +1532,12 @@ describe('timepicker directive', function () {
15321532
expect(getTimeState()).toEqual(['12', '00', 'AM']);
15331533
expect(getModelState()).toEqual([0, 0]);
15341534

1535-
minutessEl.trigger( downMouseWheelEvent );
1535+
minutesEl.trigger(downMouseWheelEvent);
15361536
$rootScope.$digest();
15371537
expect(getTimeState()).toEqual(['12', '00', 'AM']);
15381538
expect(getModelState()).toEqual([0, 0]);
15391539

1540-
minutessEl.trigger( downKeydownEvent );
1540+
minutesEl.trigger(downKeydownEvent);
15411541
$rootScope.$digest();
15421542
expect(getTimeState()).toEqual(['12', '00', 'AM']);
15431543
expect(getModelState()).toEqual([0, 0]);
@@ -1546,7 +1546,7 @@ describe('timepicker directive', function () {
15461546
it('should decrease minutes when time would rollover to a time not later than max', function() {
15471547
var down = getMinutesButton(false);
15481548
var inputs = element.find('input');
1549-
var minutessEl = inputs.eq(1);
1549+
var minutesEl = inputs.eq(1);
15501550
var downMouseWheelEvent = wheelThatMouse(-1);
15511551
var downKeydownEvent = keydown('down');
15521552

@@ -1564,15 +1564,15 @@ describe('timepicker directive', function () {
15641564
$rootScope.time = newTime(0, 0);
15651565
$rootScope.$digest();
15661566

1567-
minutessEl.trigger( downMouseWheelEvent );
1567+
minutesEl.trigger(downMouseWheelEvent);
15681568
$rootScope.$digest();
15691569
expect(getTimeState()).toEqual(['11', '59', 'PM']);
15701570
expect(getModelState()).toEqual([23, 59]);
15711571

15721572
$rootScope.time = newTime(0, 0);
15731573
$rootScope.$digest();
15741574

1575-
minutessEl.trigger( downKeydownEvent );
1575+
minutesEl.trigger( downKeydownEvent );
15761576
$rootScope.$digest();
15771577
expect(getTimeState()).toEqual(['11', '59', 'PM']);
15781578
expect(getModelState()).toEqual([23, 59]);

0 commit comments

Comments
 (0)