Skip to content
This repository was archived by the owner on May 29, 2019. It is now read-only.

Commit 9ca4ec3

Browse files
bgeverwesleycho
authored andcommitted
fix(accordion): noop for href in header to prevent page refresh with nested buttons canceling events
When nesting buttons in the header, and calling `$event.stopPropagation()` in their click handlers would cause a page refresh, because the default empty URL would be executed. By changing this into a noop, the page refresh is prevented. #3299
1 parent 6abad50 commit 9ca4ec3

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

Diff for: template/accordion/accordion-group.html

+1-1
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
<div class="panel panel-default">
22
<div class="panel-heading">
33
<h4 class="panel-title">
4-
<a href tabindex="0" class="accordion-toggle" ng-click="toggleOpen()" accordion-transclude="heading"><span ng-class="{'text-muted': isDisabled}">{{heading}}</span></a>
4+
<a href="javascript:void(0)" tabindex="0" class="accordion-toggle" ng-click="toggleOpen()" accordion-transclude="heading"><span ng-class="{'text-muted': isDisabled}">{{heading}}</span></a>
55
</h4>
66
</div>
77
<div class="panel-collapse" collapse="!isOpen">

0 commit comments

Comments
 (0)