Skip to content
This repository was archived by the owner on May 29, 2019. It is now read-only.

Commit 9d74d6c

Browse files
icfantvwesleycho
authored andcommitted
fix(tabs): update doc and fix tab demo
* update tab documentation to clarify proper use and intended behavior of the `active` attribute on both the `tabset` and `tab` directives. * fix the tab select buttons in the tab demo. Closes #5575 Fixes #5551
1 parent 4369800 commit 9d74d6c

File tree

2 files changed

+4
-4
lines changed

2 files changed

+4
-4
lines changed

src/tabs/docs/demo.html

+2-2
Original file line numberDiff line numberDiff line change
@@ -7,8 +7,8 @@
77
<div ng-controller="TabsDemoCtrl">
88
<p>Select a tab by setting active binding to true:</p>
99
<p>
10-
<button type="button" class="btn btn-default btn-sm" ng-click="scope.active = 1">Select second tab</button>
11-
<button type="button" class="btn btn-default btn-sm" ng-click="scope.active = 2">Select third tab</button>
10+
<button type="button" class="btn btn-default btn-sm" ng-click="active = 1">Select second tab</button>
11+
<button type="button" class="btn btn-default btn-sm" ng-click="active = 2">Select third tab</button>
1212
</p>
1313
<p>
1414
<button type="button" class="btn btn-default btn-sm" ng-click="tabs[1].disabled = ! tabs[1].disabled">Enable / Disable third tab</button>

src/tabs/docs/readme.md

+2-2
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,7 @@ AngularJS version of the tabs directive.
55
* `active`
66
<i class="glyphicon glyphicon-eye-open"></i>
77
_(Default: `Index of first tab`)_ -
8-
Active index of tab.
8+
Active index of tab. Setting this to an existing tab index will make that tab active.
99

1010
* `justified`
1111
<small class="badge">$</small>
@@ -31,7 +31,7 @@ AngularJS version of the tabs directive.
3131
<small class="badge">$</small>
3232
<i class="glyphicon glyphicon-eye-open"></i>
3333
_(Default: `false`)_ -
34-
Whether tab is currently selected.
34+
Whether tab is currently selected. Note that this is purely for CSS and will not physically set this tab to active.
3535

3636
* `classes`
3737
<small class="badge">$</small> -

0 commit comments

Comments
 (0)