Skip to content
This repository was archived by the owner on May 29, 2019. It is now read-only.

Commit b18dc8f

Browse files
committed
fix(accordion): revert to empty href
- Revert to empty href to avoid user triggered routing problems Fixes #4104
1 parent 394fcc2 commit b18dc8f

File tree

3 files changed

+3
-3
lines changed

3 files changed

+3
-3
lines changed

template/accordion/accordion-group.html

+1-1
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
<div class="panel panel-default">
22
<div class="panel-heading">
33
<h4 class="panel-title">
4-
<a href="#" tabindex="0" class="accordion-toggle" ng-click="$event.preventDefault(); toggleOpen()" accordion-transclude="heading"><span ng-class="{'text-muted': isDisabled}">{{heading}}</span></a>
4+
<a href tabindex="0" class="accordion-toggle" ng-click="toggleOpen()" accordion-transclude="heading"><span ng-class="{'text-muted': isDisabled}">{{heading}}</span></a>
55
</h4>
66
</div>
77
<div class="panel-collapse collapse" collapse="!isOpen">

template/tabs/tab.html

+1-1
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,3 @@
11
<li ng-class="{active: active, disabled: disabled}">
2-
<a href="#" ng-click="$event.preventDefault(); select()" tab-heading-transclude>{{heading}}</a>
2+
<a href ng-click="select()" tab-heading-transclude>{{heading}}</a>
33
</li>
+1-1
Original file line numberDiff line numberDiff line change
@@ -1 +1 @@
1-
<a href="#" ng-click="$event.preventDefault()" tabindex="-1" bind-html-unsafe="match.label | typeaheadHighlight:query"></a>
1+
<a href tabindex="-1" bind-html-unsafe="match.label | typeaheadHighlight:query"></a>

0 commit comments

Comments
 (0)