Skip to content
This repository was archived by the owner on May 29, 2019. It is now read-only.

Commit bf1768e

Browse files
committed
fix(dropdown): do not close on right click
- Do not close the dropdown on right click when open due to Firefox's behavior Closes #5052 Fixes #5051
1 parent 2a1aaf2 commit bf1768e

File tree

2 files changed

+11
-0
lines changed

2 files changed

+11
-0
lines changed

src/dropdown/dropdown.js

+2
Original file line numberDiff line numberDiff line change
@@ -36,6 +36,8 @@ angular.module('ui.bootstrap.dropdown', ['ui.bootstrap.position'])
3636

3737
if (evt && openScope.getAutoClose() === 'disabled') { return; }
3838

39+
if (evt && evt.which === 3) { return; }
40+
3941
var toggleElement = openScope.getToggleElement();
4042
if (evt && toggleElement && toggleElement[0].contains(evt.target)) {
4143
return;

src/dropdown/test/dropdown.spec.js

+9
Original file line numberDiff line numberDiff line change
@@ -79,6 +79,15 @@ describe('uib-dropdown', function() {
7979
expect(element).toHaveClass(dropdownConfig.openClass);
8080
});
8181

82+
it('should not close on right click', function() {
83+
clickDropdownToggle();
84+
element.find('ul a').trigger({
85+
type: 'mousedown',
86+
which: 3
87+
});
88+
expect(element).toHaveClass(dropdownConfig.openClass);
89+
});
90+
8291
it('should close on $location change', function() {
8392
clickDropdownToggle();
8493
expect(element).toHaveClass(dropdownConfig.openClass);

0 commit comments

Comments
 (0)