Skip to content
This repository was archived by the owner on May 29, 2019. It is now read-only.

Commit c49e9b4

Browse files
committed
fix(tabs): revert template change
- Reverts template change to tab - Adds warning if one desires more complex HTML inside the tab
1 parent de24927 commit c49e9b4

File tree

3 files changed

+6
-50
lines changed

3 files changed

+6
-50
lines changed

Diff for: src/tabs/docs/readme.md

+5-1
Original file line numberDiff line numberDiff line change
@@ -23,7 +23,7 @@ AngularJS version of the tabs directive.
2323
<i class="glyphicon glyphicon-eye-open"></i>
2424
_(Default: `false`)_ -
2525
Whether tab is currently selected.
26-
26+
2727
* `deselect()`
2828
<small class="badge">$</small>
2929
_(Default: `null`)_ -
@@ -46,3 +46,7 @@ AngularJS version of the tabs directive.
4646
### Tabset heading
4747

4848
Instead of the `heading` attribute on the `uib-tabset`, you can use an `uib-tab-heading` element inside a tabset that will be used as the tabset's header. There you can use HTML as well.
49+
50+
### Known issues
51+
52+
To use clickable elements within the tab, you have override the tab template to use div elements instead of anchor elements, and replicate the desired styles from Bootstrap's CSS. This is due to browsers interpreting anchor elements as the target of any click event, which triggers routing when certain elements such as buttons are nested inside the anchor element.

Diff for: src/tabs/tabs.css

-48
This file was deleted.

Diff for: template/tabs/tab.html

+1-1
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,3 @@
11
<li ng-class="{active: active, disabled: disabled}" class="uib-tab">
2-
<div ng-click="select()" uib-tab-heading-transclude>{{heading}}</div>
2+
<a href ng-click="select()" uib-tab-heading-transclude>{{heading}}</a>
33
</li>

0 commit comments

Comments
 (0)