Skip to content
This repository was archived by the owner on May 29, 2019. It is now read-only.

Commit c8156c7

Browse files
chrisirhcwesleycho
authored andcommitted
fix(popover): prevent wrong positioning from title
If the title is blank, ngAnimate attempts to animate ngShow so positionTooltip gets called when the title box is still visible, about to be animated to hidden. Hence, the positionTooltip receives a taller height. Avoid this by using ngIf instead. Closes #3518
1 parent 22a2144 commit c8156c7

File tree

2 files changed

+2
-2
lines changed

2 files changed

+2
-2
lines changed

template/popover/popover-template.html

+1-1
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,7 @@
55
<div class="arrow"></div>
66

77
<div class="popover-inner">
8-
<h3 class="popover-title" ng-bind="title" ng-show="title"></h3>
8+
<h3 class="popover-title" ng-bind="title" ng-if="title"></h3>
99
<div class="popover-content"
1010
tooltip-template-transclude="content"
1111
tooltip-template-transclude-scope="originScope()"></div>

template/popover/popover.html

+1-1
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,7 @@
55
<div class="arrow"></div>
66

77
<div class="popover-inner">
8-
<h3 class="popover-title" ng-bind="title" ng-show="title"></h3>
8+
<h3 class="popover-title" ng-bind="title" ng-if="title"></h3>
99
<div class="popover-content" ng-bind="content"></div>
1010
</div>
1111
</div>

0 commit comments

Comments
 (0)