Skip to content
This repository was archived by the owner on May 29, 2019. It is now read-only.

Commit ead15e3

Browse files
icfantvwesleycho
authored andcommitted
fix(accordion): add open class when expanded
- add `open` class to `.panel-collapse` when open. - fix missing closing `<` on test. Closes #4152 Fixes #3419
1 parent 22b16f0 commit ead15e3

File tree

2 files changed

+13
-2
lines changed

2 files changed

+13
-2
lines changed

src/accordion/test/accordion.spec.js

+12-1
Original file line numberDiff line numberDiff line change
@@ -114,7 +114,7 @@ describe('accordion', function () {
114114
it('should expose the controller on the view', function () {
115115
$templateCache.put('template/accordion/accordion.html', '<div>{{accordion.text}}</div>');
116116

117-
element = $compile('<accordion></accordion')(scope);
117+
element = $compile('<accordion></accordion>')(scope);
118118
scope.$digest();
119119

120120
var ctrl = element.controller('accordion');
@@ -211,6 +211,17 @@ describe('accordion', function () {
211211
scope.$digest();
212212
expect(findGroupBody(0).scope().isOpen).toBe(false);
213213
});
214+
215+
it('should add "open" when opened', function() {
216+
var group = groups.eq(0);
217+
findGroupLink(0).click();
218+
scope.$digest();
219+
expect(group).toHaveClass('panel-open');
220+
221+
findGroupLink(0).click();
222+
scope.$digest();
223+
expect(group).not.toHaveClass('panel-open');
224+
});
214225
});
215226

216227
describe('with dynamic panels', function () {

template/accordion/accordion-group.html

+1-1
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
<div class="panel panel-default">
1+
<div class="panel panel-default" ng-class="{'panel-open': isOpen}">
22
<div class="panel-heading">
33
<h4 class="panel-title">
44
<a href tabindex="0" class="accordion-toggle" ng-click="toggleOpen()" accordion-transclude="heading"><span ng-class="{'text-muted': isDisabled}">{{heading}}</span></a>

0 commit comments

Comments
 (0)