-
Notifications
You must be signed in to change notification settings - Fork 6.7k
custom class in modals backdrop #1179
Comments
Took a shot at it myself, backdrop's class changes, when stacking, to the top element's |
I think you wouldn't want to reuse |
That's what I first thought, but I'm using it in production and not once I had to have different class in modal and in backdrop. And even if I did, you can always put two classes in |
Depends on what your designers decide to do with the CSS. I prefer to stick to the single responsibility principle, and would hate to confuse users when the class is actually getting set in two places rather than one. |
Are there any plans to merge that pull request? I would argue that it's looking quite good and it's a feature that was there previously, so it would be very cool to have it back. |
+1 |
For pretty much the same reasons as #892
It could use the same class modal does and it's just a couple of lines of code, but since backdrops doesn't stack, there could a problem...
The text was updated successfully, but these errors were encountered: