Skip to content
This repository was archived by the owner on May 29, 2019. It is now read-only.

custom class in modals backdrop #1179

Closed
fxck opened this issue Oct 17, 2013 · 6 comments
Closed

custom class in modals backdrop #1179

fxck opened this issue Oct 17, 2013 · 6 comments

Comments

@fxck
Copy link

fxck commented Oct 17, 2013

For pretty much the same reasons as #892

It could use the same class modal does and it's just a couple of lines of code, but since backdrops doesn't stack, there could a problem...

@fxck
Copy link
Author

fxck commented Oct 17, 2013

Took a shot at it myself, backdrop's class changes, when stacking, to the top element's windowClass.. if I only figured out how to make pull requests to github. This for now https://gist.github.com/fxck/7028338

@davidwparker
Copy link

I think you wouldn't want to reuse windowClass but may want something else entirely: backdropClass

@fxck
Copy link
Author

fxck commented Nov 6, 2013

That's what I first thought, but I'm using it in production and not once I had to have different class in modal and in backdrop. And even if I did, you can always put two classes in windowClass: 'original oneThatsUniqueForThisBackdrop'.

@davidwparker
Copy link

Depends on what your designers decide to do with the CSS. I prefer to stick to the single responsibility principle, and would hate to confuse users when the class is actually getting set in two places rather than one.

@wocoburguesa
Copy link

Are there any plans to merge that pull request? I would argue that it's looking quite good and it's a feature that was there previously, so it would be very cool to have it back.

@rburhum
Copy link

rburhum commented Mar 19, 2014

+1

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants