Skip to content
This repository was archived by the owner on May 29, 2019. It is now read-only.

Produce bower-friendly individual module builds #2196

Closed
humidair1999 opened this issue May 14, 2014 · 28 comments
Closed

Produce bower-friendly individual module builds #2196

humidair1999 opened this issue May 14, 2014 · 28 comments
Milestone

Comments

@humidair1999
Copy link

Currently, pulling down angular-bootstrap via bower only provides the built lib for the entirety of angular-bootstrap; if you only need one or two modules, this is overkill. The bower repo also doesn't contain individual modules, such as those produced by the "Create a Build" dialog on the website.

It'd be nice if the bower repo contained the built lib for the entirety of angular-bootstrap, as WELL as individual built libs for each module, much like jQueryUI does.

Hell, it wouldn't even need to be an official bower repo; as long as there were a repo somewhere that allowed you to pull in an individual module, I'd be happy. As it is, you HAVE to build the project to produce usable individual modules.

@adamalbrecht
Copy link

+1

Came to the repo looking for this exact feature.

@slavafomin
Copy link

This is a must have! I see no other way of adding this library to my project. I don't want to include entire package if I will be using only couple of modules from it. And I don't want to manually build/re-build the package.

For now I'm going to use this approach:
bower install --save angular-bootstrap=https://github.com/angular-ui/bootstrap.git

I'm just trying to find the way to include templates in the JS files with this approach.

@TheHalcyonSavant
Copy link

+1

@mlaccetti
Copy link

This module (and SockJS) both do the same thing with shipping the source - the point of a package manager is to get the runtime stuff. Sigh. +1 for having compiled stuff jacked in.

Edit:
I went the super dirty way and did this:
bower install -S angular-ui-bootstrap=https://github.com/angular-ui/bootstrap.git#gh-pages

This way I don't have to manually do diddly, but it's still so incredibly wrong.

@matt-way
Copy link

+1

Figured this just made sense...

@jtblin
Copy link

jtblin commented Jul 20, 2014

+1

1 similar comment
@aowola
Copy link

aowola commented Aug 19, 2014

+1

@derzwen
Copy link

derzwen commented Sep 12, 2014

+1

I think it's quite important to have this. Nearly no project will use all of the angular bootstrap features. I very much like the custom build functionality provided on the homepage. But updating the project by always manually creating a new custom build and putting the file into the project is quite annoying. That's why we have dependency management tools like bower nowadays :)

@brianfeister
Copy link

+1. I love this project, but this is a major shortcoming.

@lostdalek
Copy link

+1
(angular-strap is doing it)

@chrisirhc
Copy link
Contributor

Will consider this. Considering this when rebuilding the Custom builds.

@chrisirhc chrisirhc added this to the Backlog milestone Oct 9, 2014
@fnagel
Copy link

fnagel commented Dec 19, 2014

+1

2 similar comments
@kencaron
Copy link

+1

@AshCoolman
Copy link

+1

@HeberLZ
Copy link

HeberLZ commented Jul 7, 2015

This would greatly help improve download time!

@mlaccetti
Copy link

This ticket should be closed - the bootstrap-bower repo contains bower-friendly builds by version; no more gh-pages tag hack required.

Edit (for those who don't know):
bower install --save angular-bootstrap

@wesleycho
Copy link
Contributor

This is currently fixed, as pointed out by @mlaccetti.

@chuckd
Copy link

chuckd commented Aug 14, 2015

@mlaccetti @wesleycho I can't see why this has been closed or how it has been fixed. I may just have missed something! I checked the latest angular-bootstrap in bower and it still contains only the builds with the whole library:

$ ls bower_components/angular-bootstrap
README.md
bower.json
index.js
package.json
ui-bootstrap-csp.css
ui-bootstrap-tpls.js
ui-bootstrap-tpls.min.js
ui-bootstrap.js
ui-bootstrap.min.js

The point of this issue is to request a separate .js file for each module (e.g. tooltip.{tpl.}js, typeahead.{tpl.}js). AngularStrap, as pointed out above, includes these individual files in the modules/ folder in its bower repo, so you can just pull in the bits you need.

@wesleycho wesleycho reopened this Aug 14, 2015
@wesleycho
Copy link
Contributor

Hmm, not sure what I was thinking when I closed this. But it should be noted that you can consume directly from angular-ui-bootstrap from bower and pull in the specific scripts you need from there.

@pezillionaire
Copy link

+1

@icfantv
Copy link
Contributor

icfantv commented Sep 15, 2015

@pezillionaire please do not just +1 issues. It adds no inherent value to the issue and clutters up the thread.

@pezillionaire
Copy link

@icfantv Fair enough, but how do I tell you or the keepers of this repo that I also would like this feature without cluttering up the thread? Does +1 not succinctly state that I, in addition to the many others above, would like to see this feature added to UI-Bootstrap? Does my reiteration of this issue, or what others have said before me really help when all I want/need to say is, "Yes, I too would like this."?

Yes, I would also like to have bower-friendly individual module builds of UI-Bootstrap so I don't have to weight down my project with 40 components I'm not using. I think this would be a great benefit to myself and other developers.

Thank you for making me feel welcome on my first post in your community.

@wesleycho
Copy link
Contributor

I come back to every issue - I probably read all of the issues each month (sometimes multiple times), so they don't get forgotten.

One solution now is to point Bower to this repository and to take the scripts, build the templates of interest, and to use build tooling to combine it into your dependencies - it is not the simplest solution, but any change with the distributed build has a high overhead currently, especially since we are going to be strained for resources very soon on rapid development for an Angular 2 version with a hard deadline to have a preview ready.

@pkozlowski-opensource
Copy link
Member

Few remarks:

  • bower is going away so probably there is no point in investing in automating push of individual directives into it - especially that it would require creation of many git repositories
  • npm seems to be the way to go so we could probably publish individual directives in there. Still we need to think of / solve several pbs:
    • how to handle dependencies? (deps on repos vs. bundling deps in files)
    • what to publish (scripts + templates combined or separately? or both?)
    • ....

So it is not like we can't do but, as @wesleycho points out, this needs work so someone needs to step in or ... wait till one of the core contributors have the same use-case....

@icfantv
Copy link
Contributor

icfantv commented Sep 15, 2015

@pezillionaire, That was a very good and thorough explanation and why I'd said "please do not JUST +1 issues." Had you posted that explanation either along with or in lieu of your +1, that would have added value.

As far as your sarcastic closing comment goes, I apologize if you were offended. I ask you to please take a step back and try to look at managing a popular OSS project through a project developer's eyes. We get around a dozen issues every day, most of which are not bugs and duplicates, are support requests, or developers not taking the time to properly debug their code. We've addressed how to property ask for and receive support on our website but most people don't bother to take the time to read it. As you can imagine, that can get quite frustrating because it happens over and over again with seemingly no end. OSS is very, very hard and most of us do it in our spare time, not as part of our full-time job. The lucky few work for companies that allow time to work on OSS projects.

I view our job as not only developers and maintainers of an OSS project, but also as teachers. If we can teach developers to "help us help you" then these things don't happen, time isn't wasted, and the entire community prospers.

@pezillionaire
Copy link

@wesleycho @pkozlowski-opensource and @icfantv Thank you all for your replies.

I appreciate what you are doing, especially as I do not have time to contribute to OSS outside of work.

@wesleycho Thanks! Right now, we are just adding the component, labeled as external, to our repo, it's a bit of saticfice scenario. Good luck with the Angular 2 release, looking forward to it!

@pkozlowski-opensource Was not aware of Bower's imminent demise. Is there something that will be taking over the role of managing app dependencies? npm? That being the case, I can understand the reluctance to spending time on this.

@icfantv Thank you for the apology. However in this case it seems my +1ing has stimulated discussion in an otherwise dormant thread. In the future, please don't just dismiss people who want to add a small amount of weight to an issue, it really felt disrespectful especially since I was not the first to do so in this thread. If you wanted to police this behavior it should be done from the start or state that all +1s will be removed.

@icfantv
Copy link
Contributor

icfantv commented Sep 15, 2015

@pezillionaire, I think you missed my point. Simply adding the text +1 does not add any value whatsoever to an issue. If one does it to show support and that they want the issue addressed, then one can add a thoughtful and well-reasoned comment indicating thus and, even better, submit a PR with the proposed fix after a discussion has been had as to the proper course of action, if any.

Your original comment was 'dismissed' because it, despite what you might think, didn't add any value and when pointed out, you took offense.

The irony, of course, is that in an effort prevent thread clutter with unproductive comments, this discourse has done the exact opposite.

So bottom line, in the future, please do not just add +1 text to issues.

@wesleycho
Copy link
Contributor

Closing this in favor of #4739 - this should come for free if we solve this there, and any decision will appear in that issue.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests