This repository was archived by the owner on May 29, 2019. It is now read-only.
fix(datepicker): change to dateDisabled
#4080
Closed
+1
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BREAKING CHANGE: Change validation key to `dateDisabled` to align better with Angular's convention
wesleycho
force-pushed
the
fix/datepicker-validation-key
branch
from
0862b41 to
e0085d5
Compare
|
LGTM after you change the title and you put the breaking change in the message. |
wesleycho
changed the title
dateDisableddateDisabled
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
dateDisabledto align better with Angular's conventionThis addresses #2773.