Skip to content
This repository was archived by the owner on May 29, 2019. It is now read-only.

Unable to create custom build using Mozilla Firefox 42.0 #4977

Closed
joaumg opened this issue Nov 29, 2015 · 3 comments
Closed

Unable to create custom build using Mozilla Firefox 42.0 #4977

joaumg opened this issue Nov 29, 2015 · 3 comments

Comments

@joaumg
Copy link

joaumg commented Nov 29, 2015

Steps:

  • Visit http://angular-ui.github.io/bootstrap/
  • Look at console: Error: Stack overflow rainbow.js:288:21
  • Click Create a Build
  • Select some components ( I used Collapse, Dropdown, Pagination and Tabs )
  • Click Download 4 Modules...
  • Nothing happens.

My guess: JavaScript stops running after the stack overflow.

My workaround: open chrome, reproduce steps, everything works fine.

@wesleycho
Copy link
Contributor

I wasn't able to reproduce on Firefox 41.0.2 or 42.0 on OS X. I am not sure there is anything we can do - I took a look at what line 288 was in rainbow.js, it is just a regex.exec(code)

@joaumg
Copy link
Author

joaumg commented Nov 29, 2015

I'm using Linux.
Maybe it's a platform specific issue, later on I will try to obtain more information about it.
The only thing I found for now is that the recursion occurs here

@joaumg
Copy link
Author

joaumg commented Dec 12, 2015

After some googling about the issue:

ccampbell/rainbow#123
There is also a pull request from 2013 which is still open.

I think there is no much things to do...
It's unfortunate that it works in one browser and doesn't in other ( maybe the stack limit changes from OS to OS, just a guess... ).

There could be a try / catch for the recursion ( does it work ? dunno. ), as this wouldn't break the entire site ( and making people think the site / framework is broken ).

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants