Skip to content
This repository was archived by the owner on May 29, 2019. It is now read-only.

element.addClass('dropdown-toggle'); line breaks dropdown focus #5259

Closed
Codermar opened this issue Jan 15, 2016 · 2 comments
Closed

element.addClass('dropdown-toggle'); line breaks dropdown focus #5259

Codermar opened this issue Jan 15, 2016 · 2 comments

Comments

@Codermar
Copy link

Line 311 on dropdown.js breaks accessibility dropdown focus in button.

element.addClass('dropdown-toggle');

Removing it resolves it.

Please attach to #4772

@wesleycho
Copy link
Contributor

Why would this break focus? Can you explain in more detail/post a reproduction in Plunker?

@Codermar
Copy link
Author

Not a bug, my apologies, the cause of this is the override in the bootstrap css:
.dropdown-toggle:focus {
outline: 0;
}
I am not sure why they decided to remove the outline. My accessibility QA raised this issue so I've restored the outline:
.dropdown-toggle:focus {
outline: auto 5px -webkit-focus-ring-color;
}

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

2 participants