From e84832001e17c21784e9e3808dbe52ff86cf1786 Mon Sep 17 00:00:00 2001 From: Sylvester Keil Date: Wed, 9 Sep 2015 11:04:01 +0200 Subject: [PATCH] Accordion: don't toggle open class when is-open is undefined If `is-open` is not set the accordion group is closed, but the open class will be toggled, because jQuery expects a string or boolean (ignores undefined). See here: https://github.com/jquery/jquery/blob/c9cf250daafe806818da1dd207a88a8e94a4ad16/src/attributes/classes.js#L105 --- src/accordion/accordion.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/accordion/accordion.js b/src/accordion/accordion.js index 45e5155dd9..7684995198 100644 --- a/src/accordion/accordion.js +++ b/src/accordion/accordion.js @@ -82,7 +82,7 @@ angular.module('ui.bootstrap.accordion', ['ui.bootstrap.collapse']) scope.openClass = attrs.openClass || 'panel-open'; scope.panelClass = attrs.panelClass; scope.$watch('isOpen', function(value) { - element.toggleClass(scope.openClass, value); + element.toggleClass(scope.openClass, Boolean(value)); if (value) { accordionCtrl.closeOthers(scope); }