From d337611332767c1327b2592da0129383fc0a3f8c Mon Sep 17 00:00:00 2001 From: Chenyu Zhang Date: Tue, 10 Nov 2015 16:08:20 -0500 Subject: [PATCH 1/2] fix(accordion): panel-open class not show with custom class Closes #4849 --- src/accordion/test/accordion.spec.js | 23 +++++++++++++++++++++++ template/accordion/accordion-group.html | 2 +- 2 files changed, 24 insertions(+), 1 deletion(-) diff --git a/src/accordion/test/accordion.spec.js b/src/accordion/test/accordion.spec.js index 31dd983ef5..f80e7e1453 100644 --- a/src/accordion/test/accordion.spec.js +++ b/src/accordion/test/accordion.spec.js @@ -426,6 +426,29 @@ describe('uib-accordion', function() { }); }); + describe('is-open attribute with custom class', function() { + beforeEach(function() { + var tpl = + '' + + '{{group.content}}' + + ''; + element = angular.element(tpl); + scope.groups = [ + {name: 'title 1', content: 'Content 1', open: false}, + {name: 'title 2', content: 'Content 2', open: true} + ]; + $compile(element)(scope); + scope.$digest(); + + groups = element.find('.panel'); + }); + + it('should add "panel-open" class', function(){ + expect(groups.eq(0)).not.toHaveClass('panel-open'); + expect(groups.eq(1)).toHaveClass('panel-open'); + }); + }); + describe('`is-disabled` attribute', function() { var groupBody; beforeEach(function() { diff --git a/template/accordion/accordion-group.html b/template/accordion/accordion-group.html index d5b8a256e2..c9edcbba3e 100644 --- a/template/accordion/accordion-group.html +++ b/template/accordion/accordion-group.html @@ -1,4 +1,4 @@ -
+

{{heading}}
From c5b2e35d4abcddf0a8dd1111c99d0c26e42e96f2 Mon Sep 17 00:00:00 2001 From: Chenyu Zhang Date: Tue, 10 Nov 2015 16:41:05 -0500 Subject: [PATCH 2/2] fix(accordion): do not use ng-class --- src/accordion/accordion.js | 3 ++- template/accordion/accordion-group.html | 2 +- 2 files changed, 3 insertions(+), 2 deletions(-) diff --git a/src/accordion/accordion.js b/src/accordion/accordion.js index e6c2e96dc9..be094a77bc 100644 --- a/src/accordion/accordion.js +++ b/src/accordion/accordion.js @@ -76,7 +76,8 @@ angular.module('ui.bootstrap.accordion', ['ui.bootstrap.collapse']) accordionCtrl.addGroup(scope); scope.openClass = attrs.openClass || 'panel-open'; - scope.panelClass = attrs.panelClass; + scope.panelClass = attrs.panelClass || 'panel-default'; + element.addClass(scope.panelClass); scope.$watch('isOpen', function(value) { element.toggleClass(scope.openClass, !!value); if (value) { diff --git a/template/accordion/accordion-group.html b/template/accordion/accordion-group.html index c9edcbba3e..ff5de36e0d 100644 --- a/template/accordion/accordion-group.html +++ b/template/accordion/accordion-group.html @@ -1,4 +1,4 @@ -
+

{{heading}}