Skip to content

Commit 86badfd

Browse files
fix(selection): properly update selectAll flag based on current selection
1 parent 9c256bf commit 86badfd

File tree

1 file changed

+6
-3
lines changed

1 file changed

+6
-3
lines changed

Diff for: src/features/selection/js/selection.js

+6-3
Original file line numberDiff line numberDiff line change
@@ -464,10 +464,11 @@
464464
return;
465465
}
466466

467+
var selectedRows;
467468
if (!multiSelect && !selected) {
468469
service.clearSelectedRows(grid, evt);
469470
} else if (!multiSelect && selected) {
470-
var selectedRows = service.getSelectedRows(grid);
471+
selectedRows = service.getSelectedRows(grid);
471472
if (selectedRows.length > 1) {
472473
selected = false; // Enable reselect of the row
473474
service.clearSelectedRows(grid, evt);
@@ -480,9 +481,11 @@
480481
row.setSelected(!selected);
481482
if (row.isSelected === true) {
482483
grid.selection.lastSelectedRow = row;
483-
} else {
484-
grid.selection.selectAll = false;
485484
}
485+
486+
selectedRows = service.getSelectedRows(grid);
487+
grid.selection.selectAll = grid.rows.length === selectedRows.length;
488+
486489
grid.api.selection.raise.rowSelectionChanged(row, evt);
487490
}
488491
},

0 commit comments

Comments
 (0)