fix(edit): deep edit keydown logic wasn't right

swalters · swalters · commit 9e995e9e5858 · 2015-06-12T16:10:22.000-05:00
diff --git a/src/features/edit/js/gridEdit.js b/src/features/edit/js/gridEdit.js
@@ -882,10 +882,10 @@
                   }
 
                   if ($scope.deepEdit &&
-                    evt.keyCode === uiGridConstants.keymap.LEFT ||
-                    evt.keyCode === uiGridConstants.keymap.RIGHT ||
-                    evt.keyCode === uiGridConstants.keymap.UP ||
-                    evt.keyCode === uiGridConstants.keymap.DOWN) {
+                    (evt.keyCode === uiGridConstants.keymap.LEFT ||
+                     evt.keyCode === uiGridConstants.keymap.RIGHT ||
+                     evt.keyCode === uiGridConstants.keymap.UP ||
+                     evt.keyCode === uiGridConstants.keymap.DOWN)) {
                     evt.stopPropagation();
                   }
                   // Pass the keydown event off to the cellNav service, if it exists

Original file line number	Diff line number	Diff line change
`@@ -882,10 +882,10 @@`
`882`	`882`	`}`
`883`	`883`
`884`	`884`	`if ($scope.deepEdit &&`
`885`		`- evt.keyCode === uiGridConstants.keymap.LEFT \|\|`
`886`		`- evt.keyCode === uiGridConstants.keymap.RIGHT \|\|`
`887`		`- evt.keyCode === uiGridConstants.keymap.UP \|\|`
`888`		`- evt.keyCode === uiGridConstants.keymap.DOWN) {`
	`885`	`+ (evt.keyCode === uiGridConstants.keymap.LEFT \|\|`
	`886`	`+ evt.keyCode === uiGridConstants.keymap.RIGHT \|\|`
	`887`	`+ evt.keyCode === uiGridConstants.keymap.UP \|\|`
	`888`	`+ evt.keyCode === uiGridConstants.keymap.DOWN)) {`
`889`	`889`	`evt.stopPropagation();`
`890`	`890`	`}`
`891`	`891`	`// Pass the keydown event off to the cellNav service, if it exists`