Skip to content

Commit a6b52c2

Browse files
Rafal Jozwikmportuga
Rafal Jozwik
authored andcommitted
fix(Grid.js): add column header to text read by aria when user moves through grid with keyboard
1 parent 511777e commit a6b52c2

File tree

4 files changed

+13
-5
lines changed

4 files changed

+13
-5
lines changed

Diff for: src/features/cellnav/js/cellnav.js

+7-2
Original file line numberDiff line numberDiff line change
@@ -833,6 +833,10 @@
833833
}
834834
}
835835

836+
function getAppendedColumnHeaderText(col) {
837+
return ', ' + i18nService.getSafeText('headerCell.aria.column') + ' ' + col.displayName;
838+
}
839+
836840
function getCellDisplayValue(currentRowColumn) {
837841
if (currentRowColumn.col.field === 'selectionRowHeaderCol') {
838842
// This is the case when the 'selection' feature is used in the grid and the user has moved
@@ -841,14 +845,15 @@
841845
// is or is not currently selected.
842846
return currentRowColumn.row.isSelected ? i18nService.getSafeText('search.aria.selected') : i18nService.getSafeText('search.aria.notSelected');
843847
} else {
844-
return grid.getCellDisplayValue(currentRowColumn.row, currentSelection[i].col);
848+
return grid.getCellDisplayValue(currentRowColumn.row, currentRowColumn.col);
845849
}
846850
}
847851

848852
var values = [];
849853
var currentSelection = grid.api.cellNav.getCurrentSelection();
850854
for (var i = 0; i < currentSelection.length; i++) {
851-
values.push(getCellDisplayValue(currentSelection[i]));
855+
var cellDisplayValue = getCellDisplayValue(currentSelection[i]) + getAppendedColumnHeaderText(currentSelection[i].col);
856+
values.push(cellDisplayValue);
852857
}
853858
var cellText = values.toString();
854859
setNotifyText(cellText);

Diff for: src/js/i18n/de.js

+2-1
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,8 @@
99
aria: {
1010
defaultFilterLabel: 'Filter für Spalte',
1111
removeFilter: 'Filter löschen',
12-
columnMenuButtonLabel: 'Spaltenmenü'
12+
columnMenuButtonLabel: 'Spaltenmenü',
13+
column: 'Spalte'
1314
},
1415
priority: 'Priorität:',
1516
filterLabel: "Filter für Spalte: "

Diff for: src/js/i18n/en.js

+2-1
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,8 @@
99
aria: {
1010
defaultFilterLabel: 'Filter for column',
1111
removeFilter: 'Remove Filter',
12-
columnMenuButtonLabel: 'Column Menu'
12+
columnMenuButtonLabel: 'Column Menu',
13+
column: 'Column'
1314
},
1415
priority: 'Priority:',
1516
filterLabel: "Filter for column: "

Diff for: src/js/i18n/pl.js

+2-1
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,8 @@
99
aria: {
1010
defaultFilterLabel: 'Filtr dla kolumny',
1111
removeFilter: 'Usuń filtr',
12-
columnMenuButtonLabel: 'Menu kolumny'
12+
columnMenuButtonLabel: 'Menu kolumny',
13+
column: 'Kolumna'
1314
},
1415
priority: 'Prioritet:',
1516
filterLabel: "Filtr dla kolumny: "

0 commit comments

Comments
 (0)