Skip to content

Commit cad146b

Browse files
committed
fix(core): fix #4592. this in link functions = window, not the directive.
I could not find where self.shown was used anywhere so just removed it
1 parent 9a736c9 commit cad146b

File tree

1 file changed

+1
-3
lines changed

1 file changed

+1
-3
lines changed

Diff for: src/js/core/directives/ui-grid-column-menu.js

+1-3
Original file line numberDiff line numberDiff line change
@@ -336,8 +336,6 @@ function ($timeout, gridUtil, uiGridConstants, uiGridColumnMenuService, $documen
336336
templateUrl: 'ui-grid/uiGridColumnMenu',
337337
replace: true,
338338
link: function ($scope, $elm, $attrs, uiGridCtrl) {
339-
var self = this;
340-
341339
uiGridColumnMenuService.initialize( $scope, uiGridCtrl );
342340

343341
$scope.defaultMenuItems = uiGridColumnMenuService.getDefaultMenuItems( $scope );
@@ -375,7 +373,7 @@ function ($timeout, gridUtil, uiGridConstants, uiGridColumnMenuService, $documen
375373

376374
$scope.$broadcast('hide-menu', { originalEvent: event });
377375
} else {
378-
self.shown = $scope.menuShown = true;
376+
$scope.menuShown = true;
379377
uiGridColumnMenuService.repositionMenu( $scope, column, colElementPosition, $elm, $columnElement );
380378

381379
$scope.colElement = $columnElement;

0 commit comments

Comments
 (0)