Skip to content

Commit fbdaf8d

Browse files
committed
Merge pull request #4975 from imbalind/validate
feature(validation): fix tests on IE and Opera
2 parents 271863c + a368252 commit fbdaf8d

File tree

2 files changed

+8
-10
lines changed

2 files changed

+8
-10
lines changed

src/features/validate/test/uiGridValidateDirective.spec.js

+7-7
Original file line numberDiff line numberDiff line change
@@ -72,31 +72,31 @@ describe('uiGridValidateDirective', function () {
7272

7373
switch (cellValue) {
7474
case 'A1':
75-
cell.find('input').val('').trigger('input');
75+
cell.find('input').controller('ng-model').$setViewValue('');
7676
event = jQuery.Event("keydown");
7777
event.keyCode = uiGridConstants.keymap.TAB;
7878
cell.find('input').trigger(event);
7979
digest();
8080
expect(cellContent.classList.contains('invalid')).toBe(true);
8181
break;
8282
case 'B1':
83-
cell.find('input').val('B').trigger('input');
83+
cell.find('input').controller('ng-model').$setViewValue('B');
8484
event = jQuery.Event("keydown");
8585
event.keyCode = uiGridConstants.keymap.TAB;
8686
cell.find('input').trigger(event);
8787
digest();
8888
expect(cellContent.classList.contains('invalid')).toBe(true);
8989
break;
9090
case 'A2':
91-
cell.find('input').val('A').trigger('input');
91+
cell.find('input').controller('ng-model').$setViewValue('A');
9292
event = jQuery.Event("keydown");
9393
event.keyCode = uiGridConstants.keymap.TAB;
9494
cell.find('input').trigger(event);
9595
digest();
9696
expect(cellContent.classList.contains('invalid')).toBe(false);
9797
break;
9898
case 'B2':
99-
cell.find('input').val('B2+').trigger('input');
99+
cell.find('input').controller('ng-model').$setViewValue('B2+');
100100
event = jQuery.Event("keydown");
101101
event.keyCode = uiGridConstants.keymap.TAB;
102102
cell.find('input').trigger(event);
@@ -121,7 +121,7 @@ describe('uiGridValidateDirective', function () {
121121
$timeout.flush();
122122
expect(cell.find('input').length).toBe(1);
123123

124-
cell.find('input').val('').trigger('input');
124+
cell.find('input').controller('ng-model').$setViewValue('');
125125
event = jQuery.Event("keydown");
126126
event.keyCode = uiGridConstants.keymap.TAB;
127127
cell.find('input').trigger(event);
@@ -132,7 +132,7 @@ describe('uiGridValidateDirective', function () {
132132
$timeout.flush();
133133
expect(cell.find('input').length).toBe(1);
134134

135-
cell.find('input').val('A1').trigger('input');
135+
cell.find('input').controller('ng-model').$setViewValue('A1');
136136
event = jQuery.Event("keydown");
137137
event.keyCode = uiGridConstants.keymap.TAB;
138138
cell.find('input').trigger(event);
@@ -165,7 +165,7 @@ describe('uiGridValidateDirective', function () {
165165
$timeout.flush();
166166
expect(cell.find('input').length).toBe(1);
167167

168-
cell.find('input').val('B').trigger('input');
168+
cell.find('input').controller('ng-model').$setViewValue('B');
169169
event = jQuery.Event("keydown");
170170
event.keyCode = uiGridConstants.keymap.TAB;
171171
cell.find('input').trigger(event);

src/features/validate/test/uiGridValidateService.spec.js

+1-3
Original file line numberDiff line numberDiff line change
@@ -1,14 +1,12 @@
11
describe('ui.grid.validate uiGridValidateService', function () {
22
var uiGridValidateService;
33
var $rootScope;
4-
var $q;
54

65
beforeEach(module('ui.grid.validate'));
76

8-
beforeEach(inject(function (_uiGridValidateService_, _$rootScope_, _$q_) {
7+
beforeEach(inject(function (_uiGridValidateService_, _$rootScope_) {
98
uiGridValidateService = _uiGridValidateService_;
109
$rootScope = _$rootScope_;
11-
$q = _$q_;
1210
}));
1311

1412
it('should create an empty validatorFactories object', function() {

0 commit comments

Comments
 (0)