-
Notifications
You must be signed in to change notification settings - Fork 2.5k
Please publish UI Grid to NPM #3402
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
We'll take that under advisement. Is there a reason that the bower package doesn't work for you? Would you want just the bower package duplicated to npm or something different? |
Yes, the existing bower package pushed to NPM should be fine. An increasing number of front-end projects now publish directly to NPM (http://blog.npmjs.org/post/101775448305/npm-and-front-end-packaging). Angular and other Angular-ui projects now have official NPM distributions too. Two reasons for me personally: 1) I prefer having just one package manager for all my dependencies 2) we have an internal corporate mirror of the NPM registry, but not one for bower. I understand this is probably not a concern for others :) |
Another reason |
+1 Like @jinder I prefer use only NPM as package manager and I was surprised to not found |
Workaround is to install via Github: |
Maybe the better way would be to publish https://github.com/angular-ui/bower-ui-grid on npm which contains builded files. |
@c0bra: whilst this might help some people, it's not that it doesn't work with bower. Will this make our release process longer/more complex, or does it just get automated with the rest and remain largely push button? If the latter then I guess I'm supportive, but probably not as a high priority. |
+1 to this. I echo @jinder sentiments. I wouldn't think this would make releases any more complex. It's essentially just publishing the same package you do to bower to the npm registry. Also FYI |
Hopefully ui-grid can be added to npm as part of the 3.0 release. We use npm exclusively to manage our front-end dependencies, and this is the only dependency that isn't available there. |
@rewiredpictures Thanks for the tip. I think we can use the base of the bower repo build task for doing the same thing on NPM. |
+1 for npm publish. |
+1 |
It looks like this package made it's way into npm. Yay thanks! One problem is that the |
Ah, I see. Its published as angular-ui-grid. And as @rewiredpictures said, the "main" should point to just one file. I think it should point to an index.js file requiring the source code and exporting the name like the angular sub-modules do.
A "repository" and "bugs" property in |
@aciccarello Thanks for the notes. I'll get this done for the next release. The README, repo and bugs
|
+1 for supporting CommonJS package management! MotivationI'm in the process of refactoring an app to support modern JS tooling like NPM-only, Webpack & ES6. Code ChangeA small change is needed to support CommonJS:
I have done PRs for some of my own dependencies:
Since ui-grid uses several modules I'm not sure how to proceed, but I am willing to help if needed 😄 Sources |
There are lots of things that need to be taken care of and not enough developers to go around at the moment. If you know how to make the build better please join us on gitter. |
Just as a note, I was able to include it in Webpack + ES6 with:
|
@benoror I am trying to import ui-grid to my webpack project but I get this error: ERROR in ../app-ui-common/ However I do have the proper loader for images and fonts: Any ideas? |
Solved it { test: /\.css$/, loader: ExtractTextPlugin.extract("css","file")} |
This is still a problem because travis doesn't do a push automatically yet. |
@c0bra - i am still not seeing an |
|
+1 |
@icfantv We are definitely willing to accept a PR for this. |
when i tried to import in my Angualr2 component " import * as uiGrid from "angular-ui-grid"; ". i got the below issue. After searching over internet it suggested me to install "@types/angular-ui-grid" but i got the below issue. is there is any other option to fix this. |
@ManiAmuthan, please do not hijack threads with your own support requests. This is considered very poor form. You would be better served by posting your question to stackoverflow. |
Could you please publish the new UI Grid to NPM? I can't seem to find it on there at the moment.
The text was updated successfully, but these errors were encountered: