Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

using infinite scroll while menu is open throws a [$rootScope:inprog] $digest already in progress exception #6989

Closed
Joel-Kornbluh opened this issue May 23, 2019 · 3 comments
Labels

Comments

@Joel-Kornbluh
Copy link

Joel-Kornbluh commented May 23, 2019

Bug Description

With the infiniteScroll fetaure, when the grid is loading additional data (i.e. page) while a menu or column menu is open, it will throw a [$rootScope:inprog] $digest already in progress exception.

Cause

This bug was introduced in v4.2.0 by this commit which replaces $timeout with $scope.$apply in many places for performance reasons.

Specifically, dataLoaded - which is what users call once additional data has finished loading - calls adjustScroll which calls $rootScope.$applyAsync and indirectly wraps a beginScroll event trigger which has a registered handler in the column menu which in turn calls $scope.$apply again in applyHideMenu.

Possible Fix

  1. Restore the $timeout in applyHideMenu in place of $scope.$apply, or:
  2. Use some kind of "safe" $apply wherever we use $scope.$apply/$scope.$applyAsync
@stale
Copy link

stale bot commented Jul 22, 2019

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale label Jul 22, 2019
@stale
Copy link

stale bot commented Aug 21, 2019

This issue has been automatically closed because it has not had recent activity. If you believe that this is still an issue in the latest version, feel free to re-open it. Thank you for your contributions.

@stale stale bot closed this as completed Aug 21, 2019
@Lilipi
Copy link

Lilipi commented Feb 21, 2022

Hi,
Any news about this please ?
The problem still exists. Replace $scope.$apply by $timeout in applyHideMenu doesn't seems to fix that. In fact, doing this, the menu open and close instantly...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants