You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Copy file name to clipboardExpand all lines: README.md
+6-6
Original file line number
Diff line number
Diff line change
@@ -169,7 +169,7 @@ The `assignable expressions` will be used by scroller to inject the requested va
169
169
The target scope is being defined in accordance with standard Angular rules (nested scopes and controller As syntax should be taken into account):
170
170
the scroller will traverse its parents (from the ui-scroll element's scope up to the $rootScope) to locate the target scope.
171
171
If the viewport is presented (the element marked with the [uiScrollViewport](#uiscrollviewport-directive) directive),
172
-
then the scope associated with the viewport will be a start point in target scope detecting.
172
+
then the scope associated with the viewport will be a start point in the target scope locating.
173
173
Angular $parse service is being used in `assignable expressions` implementation.
174
174
175
175
_Deprecated!_ The format `expression on controller` introduced in v1.5.0 (and deprecated in v1.6.1) can be used to explicitly target the scope associated with the specified controller as the target scope for the injection. In this format `expression` is any angular assignable expression, and `controller` is the name of controller constructor function as specified in the `ng-controller` directive.
@@ -423,22 +423,22 @@ npm test
423
423
```
424
424
425
425
This runs karma testing against temporary distributive files (./temp). We created a number of specifications which consist of more
426
-
than 160 tests. They are living at [./test](https://github.com/angular-ui/ui-scroll/tree/master/test) folder. Karma watches for temp
427
-
and test folders changes and automatically re-run tests.
426
+
than 160 tests. They are living at the [./test](https://github.com/angular-ui/ui-scroll/tree/master/test) folder. Karma watches for temp
427
+
and test folders changes and automatically re-runs tests.
428
428
429
429
__3__. To run full build use
430
430
431
431
```
432
432
npm run build
433
433
```
434
434
435
-
After developing and testing complete the build process should be run to
435
+
After developing and testing complete, the build process should be run to
436
436
a) pass through jshint,
437
437
b) generate minified versions of distributive,
438
438
c) run tests with minified distributive files,
439
-
d) obtain all necessary files in [./dist](https://github.com/angular-ui/ui-scroll/tree/master/dist) folder.
439
+
d) obtain all necessary files in the [./dist](https://github.com/angular-ui/ui-scroll/tree/master/dist) folder.
440
440
441
-
PR should include source code (./scr) and tests (./test) changes and may not include public distributive (./dist) changes.
441
+
PR should include source code (./scr) changes, may include tests (./test) changes and may not include public distributive (./dist) changes.
0 commit comments