Skip to content

Commit 632629f

Browse files
committed
v1.6.1 cleanup
1 parent 9c7eefa commit 632629f

File tree

6 files changed

+13
-13
lines changed

6 files changed

+13
-13
lines changed

README.md

+6-6
Original file line numberDiff line numberDiff line change
@@ -169,7 +169,7 @@ The `assignable expressions` will be used by scroller to inject the requested va
169169
The target scope is being defined in accordance with standard Angular rules (nested scopes and controller As syntax should be taken into account):
170170
the scroller will traverse its parents (from the ui-scroll element's scope up to the $rootScope) to locate the target scope.
171171
If the viewport is presented (the element marked with the [uiScrollViewport](#uiscrollviewport-directive) directive),
172-
then the scope associated with the viewport will be a start point in target scope detecting.
172+
then the scope associated with the viewport will be a start point in the target scope locating.
173173
Angular $parse service is being used in `assignable expressions` implementation.
174174

175175
_Deprecated!_ The format `expression on controller` introduced in v1.5.0 (and deprecated in v1.6.1) can be used to explicitly target the scope associated with the specified controller as the target scope for the injection. In this format `expression` is any angular assignable expression, and `controller` is the name of controller constructor function as specified in the `ng-controller` directive.
@@ -423,22 +423,22 @@ npm test
423423
```
424424

425425
This runs karma testing against temporary distributive files (./temp). We created a number of specifications which consist of more
426-
than 160 tests. They are living at [./test](https://github.com/angular-ui/ui-scroll/tree/master/test) folder. Karma watches for temp
427-
and test folders changes and automatically re-run tests.
426+
than 160 tests. They are living at the [./test](https://github.com/angular-ui/ui-scroll/tree/master/test) folder. Karma watches for temp
427+
and test folders changes and automatically re-runs tests.
428428

429429
__3__. To run full build use
430430

431431
```
432432
npm run build
433433
```
434434

435-
After developing and testing complete the build process should be run to
435+
After developing and testing complete, the build process should be run to
436436
a) pass through jshint,
437437
b) generate minified versions of distributive,
438438
c) run tests with minified distributive files,
439-
d) obtain all necessary files in [./dist](https://github.com/angular-ui/ui-scroll/tree/master/dist) folder.
439+
d) obtain all necessary files in the [./dist](https://github.com/angular-ui/ui-scroll/tree/master/dist) folder.
440440

441-
PR should include source code (./scr) and tests (./test) changes and may not include public distributive (./dist) changes.
441+
PR should include source code (./scr) changes, may include tests (./test) changes and may not include public distributive (./dist) changes.
442442

443443

444444
-------------------

dist/ui-scroll.js

+2-2
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

dist/ui-scroll.js.map

+1-1
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

0 commit comments

Comments
 (0)