Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Does topVisible support multiple items per row (inline, float-left) #148

Closed
david-hollifield opened this issue Mar 15, 2017 · 4 comments
Closed

Comments

@david-hollifield
Copy link

I wanted to add topVisible support to the many areas that I'm using the scroller in my app. I'm watching the topVisible attribute on my adapter, but the value never changes after the initial load when showing multiple items per row. The lines in calculateProperties that set the various topVisibleXXX properties are never hit when scrolling and multiple items per row. Everything works as it should when only showing a single item per row.

Is topVisible and multiple items per row supported?

@dhilt
Copy link
Member

dhilt commented Mar 15, 2017

@david-hollifield Unfortunately, multiple items per row feature is not supported itself, so the answer is no. There are some plans to do a refactoring around inline/float-left stuff, but this work has not been started yet. This is a long story: #8...

@david-hollifield
Copy link
Author

Man, that's too bad. The latest version has been working so well for me and 9/10 of my lists are multiple items per row lists with hundreds of items/photos that I assumed it was supported.

@dhilt
Copy link
Member

dhilt commented Mar 15, 2017

@david-hollifield There may be a workaround, I think... For example, some fixed (N) number of items per row; in that case you may create a wrapper for the datasource and pass to the scroller the group-items which consist of (N) items. But if the number of items could not be fixed... this case could not be solved with current version of the scroller directive.

@dhilt
Copy link
Member

dhilt commented Mar 26, 2018

Closed due to issue #8 duplication. Also, maybe it would be useful, horizontal scroll is supported in Angular 5+ version of the uiScroll directive (ngx-ui-scroll).

@dhilt dhilt closed this as completed Mar 26, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants