fix(uiSelectMultiple): tolerate null/undefined view value

Previously view value was checked and corrected if undefined, but then
overwritten with the invalid value again.

This is a minor commit to ensure the updated value isn't overwritten
again.

Originally authored by homerjam

Closes #967 and #1686
Supersedes #1035 #1529 #1687

Author: user378230

src/uiSelectMultipleDirective.js

@@ -162,7 +162,7 @@ uis.directive('uiSelectMultiple', ['uiSelectMinErr','$timeout', function(uiSelec
         if(!angular.isArray(ngModel.$viewValue)){
           // Have tolerance for null or undefined values
           if(angular.isUndefined(ngModel.$viewValue) || ngModel.$viewValue === null){
-            $select.selected = [];
+            ngModel.$viewValue = [];
           } else {
             throw uiSelectMinErr('multiarr', "Expected model value to be array but got '{0}'", ngModel.$viewValue);
           }

test/select.spec.js

@@ -2494,6 +2494,43 @@ describe('ui-select tests', function() {
       expect(el.scope().$select.items[1]).toEqual(jasmine.objectContaining({name: 'Amalie', email: '[email protected]'}));
     });
 
+    
+    it('should have tolerance for undefined values', function () {
+
+      scope.modelValue = undefined;
+
+      var el = compileTemplate(
+          '<ui-select multiple ng-model="modelValue" theme="bootstrap" style="width: 800px;"> \
+              <ui-select-match placeholder="Pick one...">{{$item.name}} &lt;{{$item.email}}&gt;</ui-select-match> \
+              <ui-select-choices repeat="person.email as person in people | filter: $select.search"> \
+                <div ng-bind-html="person.name | highlight: $select.search"></div> \
+                <div ng-bind-html="person.email | highlight: $select.search"></div> \
+              </ui-select-choices> \
+          </ui-select> \
+          '
+      );
+
+      expect($(el).scope().$select.selected).toEqual([]);
+    });
+
+    it('should have tolerance for null values', function () {
+
+      scope.modelValue = null;
+
+      var el = compileTemplate(
+          '<ui-select multiple ng-model="modelValue" theme="bootstrap" style="width: 800px;"> \
+              <ui-select-match placeholder="Pick one...">{{$item.name}} &lt;{{$item.email}}&gt;</ui-select-match> \
+              <ui-select-choices repeat="person.email as person in people | filter: $select.search"> \
+                <div ng-bind-html="person.name | highlight: $select.search"></div> \
+                <div ng-bind-html="person.email | highlight: $select.search"></div> \
+              </ui-select-choices> \
+          </ui-select> \
+          '
+      );
+
+      expect($(el).scope().$select.selected).toEqual([]);
+    });
+      
     it('should allow paste tag from clipboard', function() {
       scope.taggingFunc = function (name) {
         return {