Skip to content
This repository was archived by the owner on Oct 2, 2019. It is now read-only.

Added open and close event hooks for directive #1153

Closed
wants to merge 1 commit into from

Conversation

RavenHursT
Copy link

Addresses a few of the feature requests in #432

Specifically, directive APIs for onOpen and onClose callbacks.

@tarlepp
Copy link

tarlepp commented Aug 31, 2015

+1 for this

@RavenHursT
Copy link
Author

Can someone please take a look at this?

@Luxor
Copy link

Luxor commented Sep 4, 2015

+1

@RavenHursT
Copy link
Author

+1 bump?

@ghost
Copy link

ghost commented Sep 9, 2015

+1

1 similar comment
@RedPointMS
Copy link

+1

@Den-dp
Copy link
Contributor

Den-dp commented Oct 7, 2015

It may be useful, +1

@wesleycho
Copy link
Contributor

This needs rebasing, and unit tests.

@mtucciarone
Copy link

Very useful! +1

@cwagner22
Copy link

+1

@zacyang
Copy link

zacyang commented Jul 12, 2016

+1, please merge this PR back, I am also struggle on the blur event hell.

Den-dp added a commit to Den-dp/ui-select that referenced this pull request Jul 12, 2016
Den-dp added a commit to Den-dp/ui-select that referenced this pull request Jul 12, 2016
Den-dp added a commit to Den-dp/ui-select that referenced this pull request Jul 12, 2016
@Den-dp
Copy link
Contributor

Den-dp commented Jul 13, 2016

In order to push this feature I'm suggesting this #1723 PR which has a slightly updated and rebased code with a couple of unit tests.
If all this makes sense but some changes are required please let me know.

Den-dp added a commit to Den-dp/ui-select that referenced this pull request Jul 24, 2016
kboga pushed a commit to kboga/ui-select that referenced this pull request Nov 29, 2016
Adds a new `uisOpenClose` directive which allows a callback to be 
defined that is called whenever the dropdown is opened or closed.

Callback is passed an isOpen parameter which is set to true if the
dropdown has been opened, otherwise false.

Closes angular-ui#432, closes angular-ui#1153
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

9 participants