From 2023be92d64eb8d9f398e9f710ccd31c1b5ca49a Mon Sep 17 00:00:00 2001 From: Jason Gray Date: Tue, 11 Oct 2016 16:49:57 +0100 Subject: [PATCH] fix(_updateItemLocked) properly unlock locked items when lock conditions change Previously when the lock expression value changes from true to false the locked value was not removed from the locked list. --- src/uiSelectController.js | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/uiSelectController.js b/src/uiSelectController.js index 7ef150625..193c5e2ce 100644 --- a/src/uiSelectController.js +++ b/src/uiSelectController.js @@ -423,7 +423,7 @@ uis.controller('uiSelectCtrl', ctrl.close(skipFocusser); return; } - } + } _resetSearchInput(); $scope.$broadcast('uis:select', item); @@ -499,7 +499,7 @@ uis.controller('uiSelectCtrl', } if (!isLocked && lockedItemIndex > -1) { - lockedItems.splice(lockedItemIndex, 0); + lockedItems.splice(lockedItemIndex, 1); } }