Skip to content

Commit 717706d

Browse files
devversionclydin
authored andcommitted
build: migrate @schematics/angular tests to rules_js
Migrates the @schematics/angular tests to `rules_js`.
1 parent bf8e208 commit 717706d

File tree

2 files changed

+36
-39
lines changed

2 files changed

+36
-39
lines changed

packages/schematics/angular/BUILD.bazel

+14-16
Original file line numberDiff line numberDiff line change
@@ -3,14 +3,16 @@
33
# Use of this source code is governed by an MIT-style license that can be
44
# found in the LICENSE file at https://angular.dev/license
55

6-
load("@npm//@bazel/jasmine:index.bzl", "jasmine_node_test")
7-
load("//tools:defaults2.bzl", "npm_package", "ts_project")
6+
load("@npm2//:defs.bzl", "npm_link_all_packages")
7+
load("//tools:defaults2.bzl", "jasmine_test", "npm_package", "ts_project")
88
load("//tools:ts_json_schema.bzl", "ts_json_schema")
99

1010
licenses(["notice"])
1111

1212
package(default_visibility = ["//visibility:public"])
1313

14+
npm_link_all_packages()
15+
1416
# Create a list of Tuple("path/file.json", "path_file") to be used as rules
1517
ALL_SCHEMA_TARGETS = [
1618
(
@@ -81,22 +83,21 @@ ts_project(
8183
data = RUNTIME_ASSETS,
8284
module_name = "@schematics/angular",
8385
deps = [
86+
":node_modules/@angular-devkit/core",
87+
":node_modules/@angular-devkit/schematics",
8488
"//:node_modules/@inquirer/prompts",
8589
"//:node_modules/@types/node",
8690
"//:node_modules/browserslist",
8791
"//:node_modules/jsonc-parser",
88-
"//packages/angular_devkit/core:core_rjs",
89-
"//packages/angular_devkit/schematics:schematics_rjs",
90-
"//packages/angular_devkit/schematics/tasks:tasks_rjs",
9192
"//packages/schematics/angular/third_party/github.com/Microsoft/TypeScript:TypeScript_rjs",
9293
],
9394
)
9495

95-
jasmine_node_test(
96+
jasmine_test(
9697
name = "no_typescript_runtime_dep_test",
97-
srcs = ["no_typescript_runtime_dep_spec.js"],
98-
deps = [
99-
":angular",
98+
data = [
99+
"no_typescript_runtime_dep_spec.js",
100+
":angular_rjs",
100101
"//:node_modules/@types/jasmine",
101102
],
102103
)
@@ -116,20 +117,17 @@ ts_project(
116117
),
117118
deps = [
118119
":angular_rjs",
120+
":node_modules/@angular-devkit/core",
121+
":node_modules/@angular-devkit/schematics",
119122
"//:node_modules/@types/jasmine",
120123
"//:node_modules/jsonc-parser",
121-
"//packages/angular_devkit/core:core_rjs",
122-
"//packages/angular_devkit/core/node/testing:testing_rjs",
123-
"//packages/angular_devkit/schematics:schematics_rjs",
124-
"//packages/angular_devkit/schematics/tasks:tasks_rjs",
125-
"//packages/angular_devkit/schematics/testing:testing_rjs",
126124
"//packages/schematics/angular/third_party/github.com/Microsoft/TypeScript:TypeScript_rjs",
127125
],
128126
)
129127

130-
jasmine_node_test(
128+
jasmine_test(
131129
name = "angular_test",
132-
srcs = [":angular_test_lib"],
130+
data = [":angular_test_lib_rjs"],
133131
)
134132

135133
genrule(

pnpm-lock.yaml

+22-23
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

0 commit comments

Comments
 (0)