-
Notifications
You must be signed in to change notification settings - Fork 12k
Re-compile does not always trigger browser update #4453
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
this happens for minor changes. |
What kind of changes are considered to be "minor"? |
may be adding/removing a semi colon. who knows! |
I am also facing this same issue on ubuntu 16.04. When I try to add / remove a piece of code like (console.log() or a tag from html) |
Also happens to me on Windows, for a new ng project, and an existing project that had been updated to 1.0.0-beta.30. Changing a character in app.component.html triggers the browser update, but changing something in app.component.ts does not. |
I'm facing the same problem. I will investigate it little bit further, but from what I observed, I can tell changing .ts triggers recompilation, BUT browser is still seeing old data. |
I also have the same problem on Win 10. |
Same here with Win7, node v6.9.1, npm v3.10.8 |
Same issue here: Win10 pro, Node.js v7.4.0, NPM v4.1.2.
For both my upgraded and new project. |
Tested, and v1.0.0-beta.29 doesn't seem to have the same issue for me. |
I reinstalled beta 30, and I don't seem to have the issue anymore. :-\ |
@Ionaru can you please re-test and report back? make sure you run Thanks! |
FYI - To anyone who has not tried it yet. If you work directly from Master using |
We have the same issue on 3 Windows 10 machines with an existing project that had been updated to 1.0.0-beta.30 from 1.0.0-beta.26. All machines have Node 6.9.x. |
@MateEke are you able to share that repo? |
Sorry, but unfortunately not possible, as it's not an open source project. |
That's cool... can you share your package.json and angular-cli.json? |
I have some problem too. I just create new application with ng new. Then i started ng serve. Webpack compiled successfully. If i change template file or css then recompiled successful and live reload works. But if i change some in .ts files then live reloading not works and .ts files not compiled. Although webpack shown compiled successfully. If restart ng serve all changes apply successfully. OS: Ubuntu 16.04 LTS
Log after .ts changing:
|
I can confirm this is still not working, I used a completely clean installation of @angular/cli. I also tried doing the same steps using a direct clone and install of the Master branch as suggested by @jwuliger, no luck there either. Edit: I just tested this on a clean install of Ubuntu 16.10 (On a VM), and the issue is still present. |
I have the same problem on windows x64, node 6.9.5, and cli beta 30. I just started a new project so it is clean and it's probably not because of something in my code. I see this in the chrome console:
But in my shell it recompiled: webpack: Compiling...
Hash: 6ba655a01c0532602548
Time: 476ms
chunk {0} polyfills.bundle.js, polyfills.bundle.map (polyfills) 222 kB {4} [initial]
chunk {1} main.bundle.js, main.bundle.map (main) 6.63 kB {3} [initial]
chunk {2} styles.bundle.js, styles.bundle.map (styles) 10 kB {4} [initial]
chunk {3} vendor.bundle.js, vendor.bundle.map (vendor) 3.08 MB [initial]
chunk {4} inline.bundle.js, inline.bundle.map (inline) 0 bytes [entry]
webpack: Compiled successfully. |
I am seeing this too. I tried running off master as @jwuliger suggested and got a puzzling result. At first it was not working, I thought I would try to trick it into doing a reload by purposely putting and error in the code then fixing it. To see if a failed build will force an update. This however did not work, and made all following builds fail, with the same error being shown even though it does not exist in the code. I then quit the build and tried again. This time the reload started working. It now seems to be working. Versions. |
@LunaBawa is that with the latest Angular CLI version (Beta 31)? |
I am experiencing this issue on @angular/cli: 1.3.0-rc.3 |
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
OS?
Linux Kubuntu 16.10
Versions.
@angular/cli: 1.0.0-beta.30
node: 7.4.0
os: linux x64
Repro steps.
ng new newApp
cd newApp
ng serve
Edit app.component.ts (I changed 'app works!' to 'app works!!') and save.
This will trigger a re-compile.
The log given by the failure.
[WDS] App updated. Recompiling...
[WDS] App updated. Recompiling...
[WDS] Nothing changed.
Mention any other details that might be useful.
The hash between compile runs does not change.
I've seen an issue on this topic before, but it appears this is not a Windows-specific problem.
The text was updated successfully, but these errors were encountered: