-
Notifications
You must be signed in to change notification settings - Fork 12k
use html-loader
instead of raw-loader
for html files
#5363
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
We tried that a couple of times and overall we considered it unsafe. Willing to try again though. |
+1 |
@mkoczorowski Is it a really good practice though, to have a giant template so big that you need to break into multiple files? When my templates get too big, I decompose components so that each has a tolerable size template. |
@kylecordes Thanks for replying. I tend to do the same... However, there may be a use case for this. I had to embed a lot of plain html in the page some time ago, without any selectors or logic, just plain html. Creating a @component just to populate templateUrl with plain html it's a bit overkill in my opinion. Why do I need to addon javascript, increase bundle size to just to inject some plain html ? The above option will at least would give you the flexibility. It's always up to the developer what to decide should / should not this be used in a particular instance. |
Consolidating discussion in #3415 |
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
use
html-loader
instead ofraw-loader
for html files, so assets referenced in html files can be handled by file-loader correctlyThe text was updated successfully, but these errors were encountered: