Generate service : providers registered in the wrong place if { provide } is present

[cyrilletuzi]

Bug Report or Feature Request (mark with an x)

- [x] bug report -> please search issues before submitting
- [ ] feature request

Versions.

cli 1.2.1

Repro steps.

ng new test
cd test
ng g service hello

Then in AppModule, provide it like this :

@NgModule({
  declarations: [
    AppComponent
  ],
  imports: [
    BrowserModule
  ],
  providers: [{ provide: HelloService, useClass: HelloService}],
  bootstrap: [AppComponent]
})

Now, if you generate new services, with module registering option :

ng g service world --module=app

It produces :

@NgModule({
  declarations: [
    AppComponent
  ],
  imports: [
    BrowserModule
  ],
  providers: [{provide: HelloService, useClass: HelloService, providers: [WorldService]}],
  bootstrap: [AppComponent]
})

[cyrilletuzi]

The problem may be coming from this function, but didn't find yet why :

angular-cli/packages/@angular/cli/lib/ast-tools/ast-utils.ts

Line 192 in d1e13ac

function _addSymbolToNgModuleMetadata(ngModulePath: string, metadataField: string,

[cyrilletuzi]

@hansl Still there with the schematics

[denniske]

Created pull request with fix. Can somebody review?

[cyrilletuzi]

@filipesilva @Brocco This issue has been marked as a regression and is 4 months old, and has a PR waiting which is 2 months old. Can someone take care of it ?

[cyrilletuzi]

@hansl @filipesilva @Brocco This issue has been marked as a regression and is 5 months old, and has a PR waiting which is 3 months old. Can someone take care of it ?

[cyrilletuzi]

Happy to see someone is caring for this issue, but quite disagree with the new severity level : it's not just "inconvenient", it produces code that break compilation. So it should at least be "severity3: broken".

[cyrilletuzi]

Will this be fixed in v6 ?

[cyrilletuzi]

As in v6 services are not provided in the NgModule anymore, the issue is gone.

[angular-automatic-lock-bot]

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

_{This action has been performed automatically by a bot.}