Skip to content
This repository was archived by the owner on Apr 12, 2024. It is now read-only.

filters should be defined as an extensionMap #128

Closed
esprehn opened this issue Nov 6, 2010 · 2 comments
Closed

filters should be defined as an extensionMap #128

esprehn opened this issue Nov 6, 2010 · 2 comments
Milestone

Comments

@esprehn
Copy link
Contributor

esprehn commented Nov 6, 2010

For consistency reasons and future proofing filters should be defined as angular.filter(name, function) instead of just assigning directly to angular.filter.

Right now it's confusing that this is the only place you directly assign while service, widget, directive, markup and the rest use an extensionMap function.

@vojtajina
Copy link
Contributor

Agree on that. angular.filter() is built by extensionMap() as well, so it's only about changing the code:
angular.filter.name -->> angular.filter(name, function(){});

It's just search & replace...

@vojtajina
Copy link
Contributor

Closing as duplication of #490

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants