Skip to content
This repository was archived by the owner on Apr 12, 2024. It is now read-only.

Angular 1.6 breaking change to ngModelOptions #15497

Closed
wesleycho opened this issue Dec 12, 2016 · 1 comment
Closed

Angular 1.6 breaking change to ngModelOptions #15497

wesleycho opened this issue Dec 12, 2016 · 1 comment

Comments

@wesleycho
Copy link
Contributor

I apologize in advance, as this is not normally the place for this sort of issue, but I actually am in need of a bit of guidance here as to how to patch a breaking change made to Angular 1.6 in UI Bootstrap while maintaining compatibility with Angular 1.5.

Currently in UI Bootstrap, we are allowing override of ngModelOptions with defaults specified by the user - for example, like https://github.com/angular-ui/bootstrap/blob/master/src/datepicker/datepicker.js#L164-L166 . If someone is wrapping any of our components with a directive using ngModel & ngModelOptions, this will automatically wipe out the old behavior of it being not present, so it will not fallback by default but use the ngModelOptions from the parent directive.

Any suggestions?

@petebacondarwin
Copy link
Contributor

Moving the discussion to angular-ui/bootstrap#6360

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants