Skip to content

Document usage of Angularfire dev dependencies #2840

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
KingDarBoja opened this issue May 21, 2021 · 3 comments
Closed

Document usage of Angularfire dev dependencies #2840

KingDarBoja opened this issue May 21, 2021 · 3 comments

Comments

@KingDarBoja
Copy link
Contributor

Should be a good idea to document the following dependencies being added by the ng-add schematic:

  • fuzzy
  • inquirer
  • inquirer-autocomplete-prompt
  • open

In this case, only open is being used for the ng deploy --preview command (as stated in the Angular discord firebase channel) whereas the others are needed only in the ng add step, so those can be safely removed after it 🤔
@google-oss-bot
Copy link

This issue does not seem to follow the issue template. Make sure you provide all the required information.

@jamesdaniels
Copy link
Member

FWIW open and inquirer, maybe even fuzzy / autocomplete, are likely already in your node_modules between firebase-tools and ng-cli. I’m adding them to devDeps to be defensive.

@jamesdaniels jamesdaniels mentioned this issue Sep 11, 2021
Merged
12 tasks
@jamesdaniels
Copy link
Member

Dropped dev dependencies in 7.1.0-rc.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@jamesdaniels @google-oss-bot @KingDarBoja